[GitHub] dubeejw commented on issue #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
dubeejw commented on issue #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#issuecomment-337783847 @rabbah, @csantanapr, I think it might be possible to use the work here to provide a Scala OpenWhisk

[GitHub] dubeejw commented on issue #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
dubeejw commented on issue #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#issuecomment-337783847 @rabbah, @csantanapr, I think it might be possible to use the work here to provide a Scala OpenWhisk

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145589678 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145588821 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145588821 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145611754 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerClient.scala

[GitHub] markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145612104 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
markusthoemmes commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145612007 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerClient.scala

[GitHub] sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145624104 ## File path:

[GitHub] sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145624194 ## File path:

[GitHub] sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
sven-lange-last commented on a change in pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#discussion_r145625893 ## File path:

[GitHub] sven-lange-last commented on issue #2870: Remove broken containers if docker run fails

2017-10-19 Thread GitBox
sven-lange-last commented on issue #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#issuecomment-337833314 PG 4 / 906 running. This is an automated message

[GitHub] cbickel closed pull request #2861: Add batching time to BatcherTests.

2017-10-19 Thread GitBox
cbickel closed pull request #2861: Add batching time to BatcherTests. URL: https://github.com/apache/incubator-openwhisk/pull/2861 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145436189 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] dgrove-oss closed pull request #70: disable use of docker-runc by setting INVOKER_USE_RUNC to false

2017-10-18 Thread GitBox
dgrove-oss closed pull request #70: disable use of docker-runc by setting INVOKER_USE_RUNC to false URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/70 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] dgrove-oss commented on issue #70: disable use of docker-runc by setting INVOKER_USE_RUNC to false

2017-10-18 Thread GitBox
dgrove-oss commented on issue #70: disable use of docker-runc by setting INVOKER_USE_RUNC to false URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/70#issuecomment-337614118 replaced by #72 This is an

[GitHub] dgrove-oss closed pull request #71: move package update/install from init.sh into Dockerfile

2017-10-18 Thread GitBox
dgrove-oss closed pull request #71: move package update/install from init.sh into Dockerfile URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/71 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] markusthoemmes closed pull request #2868: Make redis optional on deployment

2017-10-18 Thread GitBox
markusthoemmes closed pull request #2868: Make redis optional on deployment URL: https://github.com/apache/incubator-openwhisk/pull/2868 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] dubeejw opened a new issue #2869: CLI should use filename as action name when one is not provided

2017-10-18 Thread GitBox
dubeejw opened a new issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869 When creating an action, we should assume the action name will match the filename if an action name is not provided. (1) For

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-18 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337601897 @mdeuser, @drcariel, @jessealva, @csantanapr, thoughts on the above?

[GitHub] rabbah commented on issue #2868: Make redis optional on deployment

2017-10-18 Thread GitBox
rabbah commented on issue #2868: Make redis optional on deployment URL: https://github.com/apache/incubator-openwhisk/pull/2868#issuecomment-337596432 is this change actually sound? it didn't change the invoker code which negotiates with redis - and i suspect we wouldn't see it since

[GitHub] rabbah commented on issue #1825: Support triggers and rules under package?

2017-10-19 Thread GitBox
rabbah commented on issue #1825: Support triggers and rules under package? URL: https://github.com/apache/incubator-openwhisk/issues/1825#issuecomment-337882339 Yes we should do this. Hasn?t been a priority though with a lot of work on performance and scale out.

[GitHub] rabbah commented on issue #2: Added support for configurable java action method name

2017-10-19 Thread GitBox
rabbah commented on issue #2: Added support for configurable java action method name URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/2#issuecomment-337894378 Carlos I would merge this from the command line.

[GitHub] jthomas commented on issue #86: automatically delete a feed that reaches max trigger count

2017-10-19 Thread GitBox
jthomas commented on issue #86: automatically delete a feed that reaches max trigger count URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/86#issuecomment-337883165 It would be nice to support a parameter for choosing whether to "delete when finished". I can see

[GitHub] jthomas commented on issue #89: Provide once trigger

2017-10-19 Thread GitBox
jthomas commented on issue #89: Provide once trigger URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/89#issuecomment-337883977 ? on this feature and an optional parameter to "delete after firing". I can see lots of use-cases when an action wants to schedule

[GitHub] rabbah commented on issue #2875: Added support for configurable java action method name.

2017-10-19 Thread GitBox
rabbah commented on issue #2875: Added support for configurable java action method name. URL: https://github.com/apache/incubator-openwhisk/pull/2875#issuecomment-337894670 Carlos when the runtime pr is merged shall I bump the pinned version for the base image in this pr?

[GitHub] jthomas commented on issue #1825: Support triggers and rules under package?

2017-10-19 Thread GitBox
jthomas commented on issue #1825: Support triggers and rules under package? URL: https://github.com/apache/incubator-openwhisk/issues/1825#issuecomment-337881669 Is this still planned? This is an automated message from the

[GitHub] mdeuser commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-18 Thread GitBox
mdeuser commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337607239 What happens in the case of `wsk action create myaction`, where `myaction` is a file? i guess this

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-18 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337610607 In that case, we would have to fail if a kind is not specified and an extension that does not map to a

[GitHub] sven-lange-last opened a new pull request #2870: Remove broken containers if docker run fails

2017-10-18 Thread GitBox
sven-lange-last opened a new pull request #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870 If `docker run` fails with exit code 125 and prints a valid container ID to stdout, a broken Docker container was left behind. This PR

[GitHub] dgrove-oss commented on issue #73: use metadata.name for INVOKER_NAME for statefulsets

2017-10-18 Thread GitBox
dgrove-oss commented on issue #73: use metadata.name for INVOKER_NAME for statefulsets URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/73#issuecomment-337671670 @jcrossley3 @rabbah -- address comment from review of #72

[GitHub] sven-lange-last commented on issue #2870: Remove broken containers if docker run fails

2017-10-18 Thread GitBox
sven-lange-last commented on issue #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#issuecomment-337674662 @markusthoemmes please attend to this PR. This is an

[GitHub] sven-lange-last commented on issue #2870: Remove broken containers if docker run fails

2017-10-18 Thread GitBox
sven-lange-last commented on issue #2870: Remove broken containers if docker run fails URL: https://github.com/apache/incubator-openwhisk/pull/2870#issuecomment-337663296 PG 4 / 904 in queue. This is an automated message

[GitHub] csantanapr closed pull request #2544: Allow CLI to Save Code from Action

2017-10-18 Thread GitBox
csantanapr closed pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] houshengbo commented on issue #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
houshengbo commented on issue #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#issuecomment-337435101 PG 1 2154 passed. This is an automated message

[GitHub] houshengbo commented on issue #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
houshengbo commented on issue #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#issuecomment-337647710 PG 2158 This is an automated message

[GitHub] jasonpet opened a new pull request #100: increase test case wait time on trigger creation and deletion

2017-10-18 Thread GitBox
jasonpet opened a new pull request #100: increase test case wait time on trigger creation and deletion URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/100 a test is randomly failing when checking for activations too soon (before the provider has received the change

[GitHub] dgrove-oss opened a new pull request #73: use metadata.name for INVOKER_NAME for statefulsets

2017-10-18 Thread GitBox
dgrove-oss opened a new pull request #73: use metadata.name for INVOKER_NAME for statefulsets URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/73 This is an automated message from the Apache Git Service.

[GitHub] troyibm commented on issue #29: stderr: Debugger listening on [::]:5858

2017-10-18 Thread GitBox
troyibm commented on issue #29: stderr: Debugger listening on [::]:5858 URL: https://github.com/apache/incubator-openwhisk-debugger/issues/29#issuecomment-337633380 I get this too. I've haven't found a work around. This is

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145446441 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] troyibm commented on issue #29: stderr: Debugger listening on [::]:5858

2017-10-18 Thread GitBox
troyibm commented on issue #29: stderr: Debugger listening on [::]:5858 URL: https://github.com/apache/incubator-openwhisk-debugger/issues/29#issuecomment-337633380 I get this too This is an automated message from the Apache

[GitHub] rabbah closed pull request #72: Fix travis builds by combining PR70 and PR71

2017-10-18 Thread GitBox
rabbah closed pull request #72: Fix travis builds by combining PR70 and PR71 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/72 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jcrossley3 commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71

2017-10-18 Thread GitBox
jcrossley3 commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/72#discussion_r145466009 ## File path: kubernetes/invoker/invoker.yml ## @@ -70,6 +70,12 @@ spec:

[GitHub] jcrossley3 commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71

2017-10-18 Thread GitBox
jcrossley3 commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/72#discussion_r145466009 ## File path: kubernetes/invoker/invoker.yml ## @@ -70,6 +70,12 @@ spec:

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-18 Thread GitBox
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r145439274 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,86 @@ func getExec(args

[GitHub] mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action

2017-10-18 Thread GitBox
mdeuser commented on a change in pull request #2544: Allow CLI to Save Code from Action URL: https://github.com/apache/incubator-openwhisk/pull/2544#discussion_r145439348 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -495,6 +513,86 @@ func getExec(args

[GitHub] dgrove-oss commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71

2017-10-18 Thread GitBox
dgrove-oss commented on a change in pull request #72: Fix travis builds by combining PR70 and PR71 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/72#discussion_r145467873 ## File path: kubernetes/invoker/invoker.yml ## @@ -70,6 +70,12 @@ spec:

[GitHub] dgrove-oss commented on issue #2874: explore using zookeeper as persistent store for dynamic invokerId assignment

2017-10-18 Thread GitBox
dgrove-oss commented on issue #2874: explore using zookeeper as persistent store for dynamic invokerId assignment URL: https://github.com/apache/incubator-openwhisk/issues/2874#issuecomment-337707123 please assign to me. I will look at this within the next couple of weeks.

[GitHub] dgrove-oss opened a new pull request #2871: Invokers only require Redis if using dynamic Id assignment

2017-10-18 Thread GitBox
dgrove-oss opened a new pull request #2871: Invokers only require Redis if using dynamic Id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2871 Make REDIS_HOST_NAME and REDIS_HOST_PORT optional for the invoker and only trap as a configuration error when the invoker

[GitHub] dgrove-oss opened a new issue #2872: invoker command line support for dynamicId assignment

2017-10-18 Thread GitBox
dgrove-oss opened a new issue #2872: invoker command line support for dynamicId assignment URL: https://github.com/apache/incubator-openwhisk/issues/2872 As discussed in the review of https://github.com/apache/incubator-openwhisk/pull/2689, for Mesos it is not feasible to use environment

[GitHub] dgrove-oss commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment

2017-10-18 Thread GitBox
dgrove-oss commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2871#discussion_r145511354 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala

[GitHub] houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145513189 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,22 @@ var

[GitHub] csantanapr commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
csantanapr commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145499191 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,39 @@ var

[GitHub] houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145501655 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,39 @@ var

[GitHub] mrutkows opened a new issue #609: Annotations on Actions only work if "web export" exists

2017-10-18 Thread GitBox
mrutkows opened a new issue #609: Annotations on Actions only work if "web export" exists URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/609 It appears at some point (perhaps when we added support for "web actions" that the ComposeActions() function has logic that

[GitHub] dgrove-oss commented on issue #2871: Invokers only require Redis if using dynamic Id assignment

2017-10-18 Thread GitBox
dgrove-oss commented on issue #2871: Invokers only require Redis if using dynamic Id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2871#issuecomment-337688868 Per discussion in slack with @jrcrossley3.

[GitHub] rabbah commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment

2017-10-18 Thread GitBox
rabbah commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2871#discussion_r145507456 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala ##

[GitHub] rabbah commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment

2017-10-18 Thread GitBox
rabbah commented on a change in pull request #2871: Invokers only require Redis if using dynamic Id assignment URL: https://github.com/apache/incubator-openwhisk/pull/2871#discussion_r145507456 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala ##

[GitHub] dgrove-oss commented on issue #2872: invoker command line support for dynamicId assignment

2017-10-18 Thread GitBox
dgrove-oss commented on issue #2872: invoker command line support for dynamicId assignment URL: https://github.com/apache/incubator-openwhisk/issues/2872#issuecomment-337691014 Please label as enhancement and assign to me. I plan to work on this next week.

[GitHub] mdeuser commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
mdeuser commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145510637 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,22 @@ var

[GitHub] houshengbo opened a new pull request #42: Allow CLI to Save Code from Action (#2544)

2017-10-18 Thread GitBox
houshengbo opened a new pull request #42: Allow CLI to Save Code from Action (#2544) URL: https://github.com/apache/incubator-openwhisk-client-go/pull/42 * Allow CLI to Save Code from Action * Formatting changes * Test refactor * Update test * Refactor *

[GitHub] dubeejw opened a new pull request #2873: Add documentation for save action feature

2017-10-18 Thread GitBox
dubeejw opened a new pull request #2873: Add documentation for save action feature URL: https://github.com/apache/incubator-openwhisk/pull/2873 Explains to users how to save code from an existing action. This is an automated

[GitHub] houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145513189 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,22 @@ var

[GitHub] houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
houshengbo commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145513189 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,22 @@ var

[GitHub] mdeuser commented on a change in pull request #2864: Add the support of certificate checking for secure mode

2017-10-18 Thread GitBox
mdeuser commented on a change in pull request #2864: Add the support of certificate checking for secure mode URL: https://github.com/apache/incubator-openwhisk/pull/2864#discussion_r145529633 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -94,30 +94,22 @@ var

[GitHub] starpit commented on issue #79: No tests to cover error handling?

2017-10-20 Thread GitBox
starpit commented on issue #79: No tests to cover error handling? URL: https://github.com/apache/incubator-openwhisk-client-js/issues/79#issuecomment-338193133 I see. Yes, there may be a test gap for eg requesting a non existing action, package, etc. Or non-overwriting creates against an

[GitHub] mrutkows commented on issue #622: Add unit tests to support "in-line" code on "function" keyword

2017-10-23 Thread GitBox
mrutkows commented on issue #622: Add unit tests to support "in-line" code on "function" keyword URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/622#issuecomment-338776928 need to assure code "errors out: if typo and exists gracefully with an error message to user

[GitHub] pritidesai commented on issue #617: Support "project" as a synonym for "application"

2017-10-23 Thread GitBox
pritidesai commented on issue #617: Support "project" as a synonym for "application" URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/617#issuecomment-338777113 Can not update title to indicate Priti working on it ...

[GitHub] mrutkows opened a new issue #622: Add unit tests to support "in-line" code on "function" keyword

2017-10-23 Thread GitBox
mrutkows opened a new issue #622: Add unit tests to support "in-line" code on "function" keyword URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/622 Need to assure we test for support of in-line code, for example: ``` function: | function

[GitHub] mdeuser commented on a change in pull request #2877: Better error controller message for authorization failure

2017-10-23 Thread GitBox
mdeuser commented on a change in pull request #2877: Better error controller message for authorization failure URL: https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146383888 ## File path:

[GitHub] abaruni commented on issue #101: Trigger management

2017-10-23 Thread GitBox
abaruni commented on issue #101: Trigger management URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/101#issuecomment-338794042 @csantanapr @jasonpet This is an automated message from the Apache Git

[GitHub] abaruni commented on issue #137: Trigger management

2017-10-23 Thread GitBox
abaruni commented on issue #137: Trigger management URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/137#issuecomment-338794088 @csantanapr @jasonpet This is an automated message from the Apache Git

[GitHub] mrutkows commented on issue #614: Add the support to read env variable for package name

2017-10-23 Thread GitBox
mrutkows commented on issue #614: Add the support to read env variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338797042 @houshengbo Priti brings up a validate request for an additional test(s) to assure it works on multiples

[GitHub] dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create

2017-10-23 Thread GitBox
dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create URL: https://github.com/apache/incubator-openwhisk/pull/2887#issuecomment-338799697 Looks like allowing one argument was on purpose when creating a docker action, but I don't think what is

[GitHub] mrutkows opened a new issue #624: Document "main" key support on Action

2017-10-23 Thread GitBox
mrutkows opened a new issue #624: Document "main" key support on Action URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/624 In theory, we support aliasing a function with a name other than "main" to "main" as this is what our runtime containers expect. Verify

[GitHub] dubeejw opened a new pull request #2887: Check for correct number of minimal arguments on action create

2017-10-23 Thread GitBox
dubeejw opened a new pull request #2887: Check for correct number of minimal arguments on action create URL: https://github.com/apache/incubator-openwhisk/pull/2887 Currently the argument length check passes successfully when only one argument is passed to action create. Instead of

[GitHub] alexkli commented on issue #2852: invoker: use locally available image if docker pull fails

2017-10-23 Thread GitBox
alexkli commented on issue #2852: invoker: use locally available image if docker pull fails URL: https://github.com/apache/incubator-openwhisk/pull/2852#issuecomment-338757493 Using a "whisk" prefix alone does not work, for wsk action create foo foo.js --docker wisk/proxyaction

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-23 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338784689 Good discussion. Actually found a bug in the existing code when looking into action create

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-23 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338785713 I have started implementing the suggestions here for my own personal usage as it makes things easier for

[GitHub] rabbah commented on a change in pull request #2877: Better error controller message for authorization failure

2017-10-23 Thread GitBox
rabbah commented on a change in pull request #2877: Better error controller message for authorization failure URL: https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146384623 ## File path: core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala

[GitHub] mrutkows commented on issue #331: Delete dead code - manifestreader.go

2017-10-23 Thread GitBox
mrutkows commented on issue #331: Delete dead code - manifestreader.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/331#issuecomment-338777340 @pritidesai is this still an issue? dead code still there?

[GitHub] pritidesai commented on issue #331: Delete dead code - manifestreader.go

2017-10-23 Thread GitBox
pritidesai commented on issue #331: Delete dead code - manifestreader.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/331#issuecomment-338781955 Yup I have updated link in description. This is an

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-23 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338799316 Looks like we currently allow actions to be created with only the action name when the creating docker

[GitHub] rabbah commented on issue #2884: health actions can reuse containers and may not flag an unhealthy invoker

2017-10-23 Thread GitBox
rabbah commented on issue #2884: health actions can reuse containers and may not flag an unhealthy invoker URL: https://github.com/apache/incubator-openwhisk/issues/2884#issuecomment-338803562 With multiple active controllers and no sharding, a status but flip will cause multiple

[GitHub] mrutkows opened a new issue #623: Support "blackbox" Docker images

2017-10-23 Thread GitBox
mrutkows opened a new issue #623: Support "blackbox" Docker images URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/623 This has been a discussion since last Sept. and asked Daisy to look into supporting at that time. Need to track this work via this issue. ```

[GitHub] mrutkows commented on issue #614: Add the support to read env variable for package name

2017-10-23 Thread GitBox
mrutkows commented on issue #614: Add the support to read env variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338786406 @houshengbo thanks for adding additional tests for the "concatenation" of env. variable strings with

[GitHub] abaruni opened a new pull request #137: Trigger management

2017-10-23 Thread GitBox
abaruni opened a new pull request #137: Trigger management URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/137 this PR is for fetching the current configuration and status of a feed trigger This is

[GitHub] abaruni opened a new pull request #101: Trigger management

2017-10-23 Thread GitBox
abaruni opened a new pull request #101: Trigger management URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/101 this PR is for the fetching of the current configuration and status of a feed trigger This

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-23 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338799316 Looks like we currently allow actions to be created with only the action name when creating docker

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-23 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338799316 Looks like we currently allow actions to be created with only the action name when creating docker

[GitHub] dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create

2017-10-23 Thread GitBox
dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create URL: https://github.com/apache/incubator-openwhisk/pull/2887#issuecomment-338805982 @mdeuser, looks like there is more at play here. Will make updates and see what you think.

[GitHub] houshengbo commented on issue #614: Add the support to read env variable for package name

2017-10-23 Thread GitBox
houshengbo commented on issue #614: Add the support to read env variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338811026 @pritidesai @mrutkows I have added the coverage of multiple packages.

[GitHub] dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create

2017-10-23 Thread GitBox
dubeejw commented on issue #2887: Check for correct number of minimal arguments on action create URL: https://github.com/apache/incubator-openwhisk/pull/2887#issuecomment-338809287 Currently when providing the sequence and docker flags during action create or update, an error message is

[GitHub] markusthoemmes commented on issue #2880: Gradle Build Failure (Could not determine java version from '9.0.1')

2017-10-23 Thread GitBox
markusthoemmes commented on issue #2880: Gradle Build Failure (Could not determine java version from '9.0.1') URL: https://github.com/apache/incubator-openwhisk/issues/2880#issuecomment-338563603 Duplicate of #2840. We'll need to bump our Scala versions to support Java 9. After

[GitHub] markusthoemmes closed pull request #2885: Fix invoker build break

2017-10-23 Thread GitBox
markusthoemmes closed pull request #2885: Fix invoker build break URL: https://github.com/apache/incubator-openwhisk/pull/2885 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] cbickel commented on issue #2665: Add ability to use all controllers round robin

2017-10-23 Thread GitBox
cbickel commented on issue #2665: Add ability to use all controllers round robin URL: https://github.com/apache/incubator-openwhisk/pull/2665#issuecomment-336920701 PG3#1191 is ? This is an automated message from the Apache

[GitHub] rabbah commented on a change in pull request #2576: Configure components via pureconfig.

2017-10-23 Thread GitBox
rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270132 ## File path: common/scala/transformEnvironment.sh ## @@ -0,0 +1,32 @@ +#!/bin/bash +

[GitHub] rabbah commented on a change in pull request #2576: Configure components via pureconfig.

2017-10-23 Thread GitBox
rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146268977 ## File path: common/scala/build.gradle ## @@ -13,6 +13,8 @@ dependencies { compile

[GitHub] rabbah commented on a change in pull request #2576: Configure components via pureconfig.

2017-10-23 Thread GitBox
rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146269623 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala ##

[GitHub] rabbah commented on a change in pull request #2576: Configure components via pureconfig.

2017-10-23 Thread GitBox
rabbah commented on a change in pull request #2576: Configure components via pureconfig. URL: https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270391 ## File path: core/controller/src/main/resources/application.conf ## @@ -2,6 +2,13 @@ include

  1   2   3   4   5   6   7   8   9   10   >