[GitHub] cbickel commented on issue #2938: Convert inline code to attachment in database
cbickel commented on issue #2938: Convert inline code to attachment in database URL: https://github.com/apache/incubator-openwhisk/pull/2938#issuecomment-366887847 Why has this been merged? What about the proposals I made? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #2938: Convert inline code to attachment in database
cbickel commented on issue #2938: Convert inline code to attachment in database URL: https://github.com/apache/incubator-openwhisk/pull/2938#issuecomment-343069496 My suggestion for adding the Design doc would be, doing it manually. The reasons are: - We need the doc only for a few days - We have no task yet, that adds a design doc to a production environment (wipedb and initdb) delete the database as well. And if we add a job, this job would only be for this Design doc. Because all other Design docs should not be touched, otherwise they will be recomputed and a system with a large database has an outage (at least for the list commands) - I think we don't need the doc in the pipeline (travis, ...) as the database is wiped there before a new build starts Instead I'd suggest to write a step-by-step manual, how to update the database without any disruptions and take the creation and the deletion afterwards of the design doc as one step in this guide. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cbickel commented on issue #2938: Convert inline code to attachment in database
cbickel commented on issue #2938: Convert inline code to attachment in database URL: https://github.com/apache/incubator-openwhisk/pull/2938#issuecomment-342841994 I like this little script to update the database schema. But one thing that comes into my mind is: If you have large databases, it could take a very long time to update the actions, because you are getting all the documents by its own. What do you think about creating a design doc, that returns only the actions, thats still need to be modified? Of cause, this design doc can be deleted afterwards. Another aspect to make this script faster (if you want it to), would be batching. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
