[GitHub] drcariel opened a new pull request #3531: More test clean up

2018-04-11 Thread GitBox
drcariel opened a new pull request #3531: More test clean up
URL: https://github.com/apache/incubator-openwhisk/pull/3531
 
 
   
   My attempt to finish up the final 3 files in 
https://github.com/apache/incubator-openwhisk-cli/issues/259
   along with some other test clean up
   
   CLI companion https://github.com/apache/incubator-openwhisk-cli/pull/270
   
   ## Description
   
   
   renaming Basic tests to reflect what is being tested (wsk REST) in order to 
avoid duplicate naming issues elsewhere
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#)
   https://github.com/apache/incubator-openwhisk-cli/issues/259
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel opened a new pull request #3531: More test clean up

2018-04-10 Thread GitBox
drcariel opened a new pull request #3531: More test clean up
URL: https://github.com/apache/incubator-openwhisk/pull/3531
 
 
   
   My attempt to finish up the final 3 files in 
https://github.com/apache/incubator-openwhisk-cli/issues/259
   along with some other test clean up
   
   CLI companion https://github.com/apache/incubator-openwhisk-cli/pull/270
   
   ## Description
   
   
   renaming Basic tests to reflect what is being tested (wsk REST) in order to 
avoid duplicate naming issues elsewhere
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#)
   https://github.com/apache/incubator-openwhisk-cli/issues/259
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] drcariel opened a new pull request #3531: More test clean up

2018-04-06 Thread GitBox
drcariel opened a new pull request #3531: More test clean up
URL: https://github.com/apache/incubator-openwhisk/pull/3531
 
 
   
   My attempt to finsih up the final 3 files in 
https://github.com/apache/incubator-openwhisk-cli/issues/259
   along with some other test clean up
   
   ## Description
   
   
   renaming Basic tests to reflect what is being tested (wsk REST) in order to 
avoid duplicate naming issues elsewhere
   
   ## Related issue and scope
   
   - [x] I opened an issue to propose and discuss this change (#)
   https://github.com/apache/incubator-openwhisk-cli/issues/259
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [x] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services