[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-387806564 @csantanapr, just need a . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-387483534 @rabbah, looks like caching is enabled/disabled on the `WhiskAction` singleton level, which is common code shared among the controller and invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-383188018 PG4 1600 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-382812283 PG4 1600 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-382407416 @rabbah, @markusthoemmes, thoughts on this one? Seems like there's a fairly nice performance boost for invoking Java actions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from CouchDB? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from Cloudant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching actions from disk will be faster than fetching them from CouchDB? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381743878 I'm not very concerned about the controller caching Java actions. Mostly the action invoke path is used in the controller. With that action invoke API in the controller, only an action metadata is cached, which does not include the action code. @chetanmeh, do you think fetching from actions from disk will be faster than fetching them from Cloudant? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381727877 @bbrowning, how many invokers are you using in your test cluster? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381200828 @bbrowning, do you think `key` needs to be change in `attach` and `put` as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381200828 @bbrowning, do you think `key` needs to be change in `attach` and `put` as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381187596 @bbrowning, thanks for the feedback! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
