[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-382037781 @daisy-ycguo After I added the licenses of dependencies, I think the current contents of NOTICE and LICENSE have something overlapping. For example, they both explain the licenses of the dependencies. To me, other packages, like Pflag, unix, sys, etc, are the source code dependencies, not the existing components of the project, so we need to remove them from the notice, and keep them in the LICENSE. One example for the component of the project can be openwhisk core needs to deploy kafka, zookeeper services, which are not part of the scala source code, but the necessity of the services. They are components of the openwhisk core service. Kafka and Zookeeper are the components not developed by openwhisk, but used by openwhisk to provide services. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-382037781 @daisy-ycguo After I added the licenses of dependencies, I think the current contents of NOTICE and LICENSE have something overlapping. For example, they both explain the licenses of the dependencies. To me, other packages, like Pflag, unix, sys, etc, are the source code dependencies, not the existing components of the project, so we need to remove them from the notice, and keep them in the LICENSE. One example for the component of the project can be openwhisk core needs to deploy kafka, zookeeper services, which are not part of the scala source code, but the necessity of the services. They are components of the openwhisk core service. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE
houshengbo commented on issue #271: Add the licenses of the dependencies into LICENSE URL: https://github.com/apache/incubator-openwhisk-cli/pull/271#issuecomment-381622654 @daisy-ycguo I have added a folder named licenses to host all the license content, with the references in the LICENSE.txt file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
