[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox 
jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898928
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox 
jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898998
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books post for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox 
jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898965
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} delete for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books get for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox 
jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898856
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
+https://${APIHOST}:9001/api/${GENERATED_API_ID}/club/books
+ok: created api /club/books/{isbn} put for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jpkessle commented on a change in pull request #3352: API GW doc update to include path parameter example

2018-03-07 Thread GitBox 
jpkessle commented on a change in pull request #3352: API GW doc update to 
include path parameter example
URL: 
https://github.com/apache/incubator-openwhisk/pull/3352#discussion_r172898796
 
 

 ##
 File path: docs/apigateway.md
 ##
 @@ -192,14 +205,16 @@ Now let's restore the API named `Book Club` by using the 
file `club-swagger.json
 wsk api create --config-file club-swagger.json
 ```
 ```
-ok: created api /books delete for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books get for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books post for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
-ok: created api /books put for action deleteBook
-https://${APIHOST}:9001/api/21ef035/club/books
+ok: created api /club/books/{isbn} get for action deleteBook
 
 Review comment:
   deleteBook > deleteBooks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services