[GitHub] lzbj commented on issue #2475: Use error string indirection instead of copying.

2017-07-17 Thread git 
lzbj commented on issue #2475: Use error string indirection instead of copying.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2475#issuecomment-315930382
 
 
   Ok, np, close this one. Thanks for your feedback.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lzbj commented on issue #2475: Use error string indirection instead of copying.

2017-07-17 Thread git 
lzbj commented on issue #2475: Use error string indirection instead of copying.
URL: 
https://github.com/apache/incubator-openwhisk/pull/2475#issuecomment-315692566
 
 
   @mdeuser, I suggest we keep this pr change, since as you see the 
MakeWskErrorFromWskError was designed to handle err pointers, the error was in 
essence is string. Nevertheless, It's up to you decide.
   
   Yes I'll create another PR about the const change.
   Anyway, thank you guys for help clarify and review. Appreciate it.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services