[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-366723567 Marked as blocked and assigned to @chetanmeh. Please ping through once you think we're ready to go ahead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365217747 Error is: ``` gradle :tests:compileTestScala FAILURE: Build failed with an exception. * Where: Build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle' line: 1 * What went wrong: Could not compile build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle'. > startup failed: build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle': 1: unable to resolve class org.scoverage.ScoverageReport @ line 1, column 1. import org.scoverage.ScoverageReport ^ 1 error * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0. See https://docs.gradle.org/4.5.1/userguide/command_line_interface.html#sec:command_line_warnings ``` as expected. One example is: https://github.com/apache/incubator-openwhisk-package-alarms This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365217747 Error is: ``` gradle :tests:compileTestScala FAILURE: Build failed with an exception. * Where: Build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle' line: 1 * What went wrong: Could not compile build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle'. > startup failed: build file '/Users/markusthoemmes/dev/bluewhisk/open/tests/build.gradle': 1: unable to resolve class org.scoverage.ScoverageReport @ line 1, column 1. import org.scoverage.ScoverageReport ^ 1 error * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0. See https://docs.gradle.org/4.5.1/userguide/command_line_interface.html#sec:command_line_warnings ``` as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-365181126 @csantanapr @chetanmeh Merging this change will break **all** repositories which depend on the main repository. The integration of all packages for instances is done in a way, that changes like these are not possible at only one place. Travis will not tell you this but you can easily verify by trying to run a test locally. How do you want to proceed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-364995590 @chetanmeh can you hook this up into the travis build? (If that makes any sense). So we can know it actually runs/works? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats
markusthoemmes commented on issue #3249: #3243 - Use gradle scoverage to collect test coverage stats URL: https://github.com/apache/incubator-openwhisk/pull/3249#issuecomment-363162207 Neaat, thanks for doing this! ? Does this enable any means of integration/automization? I.e.: Flag a PR if it reduces coverage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
