[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name
pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-367820754 yup we will be using `default` package as a reserved package name, i have the changes with integration test ready, after merging PR #743, will update my fork and create a new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name
pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-367820754 yup we will be using `default` package as a reserved package name, i have the changes with integration test ready, after merging PR#743, will update my fork and create a new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name
pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364292402 After talking to Matt and scoping this feature of creating OW entities under `namespace/` rather than `namespace/`, its much more feasible (from time, complexity, compatibility, and consistency perspective) to add support for package name `default` in `wskdeploy`. When a package name is set to `default` in manifest/deployment files, `wskdeploy` will generate warnings (1) `Package name 'default' is reserved.` and (2) all OW entities specified in manifest file under `default` package will be created under your namespace `/`. For example, action `helloNodejs`, trigger `locationUpdate`, and rule `hellorule` in the following example will be created under `/` ``` packages: default: actions: # helloworld action in NodeJS helloNodejs: function: actions/hello.js triggers: locationUpdate: rules: hellorule: trigger: locationUpdate action: helloNodejs ``` Priority: Critical Let me know your comments/feedback. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name
pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364292402 After talking to Matt and scoping this feature of creating OW entities under `namespace/` rather than `namespace/`, its much more feasible (from time, complexity, compatibility, and consistency perspective) to add support for package name `default` in `wskdeploy`. When a package name is set to `default` in manifest/deployment files, `wskdeploy` will generate warnings (1) `Package name 'default' is reserved.` and (2) all OW entities specified in manifest file under `default` package will be created under your namespace `/`. For example, action `helloNodejs`, trigger `locationUpdate`, and rule `hellorule` in the following example will be created under `/` ``` packages: default: actions: # helloworld action in NodeJS helloNodejs: function: actions/hello.js triggers: locationUpdate: rules: hellorule: trigger: locationUpdate action: helloNodejs ``` Priority: Critical This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name
pritidesai commented on issue #681: proper handling of 'default' package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-360298242
As package `default` is a reserved package name, when we invoke `wskdeploy`
with this kind of manifest:
```
packages:
default:
actions:
# helloworld action in NodeJS
helloNodejs:
function: actions/hello.js
...
```
It fails with:
```
./wskdeploy -p tests/src/integration/helloworld/
...
Error: Deployment did not complete sucessfully. Run `wskdeploy undeploy` to
remove partially deployed assets.
Error: servicedeployer.go [1499]: [ERROR_WHISK_CLIENT_ERROR]: Error code:
144: Package name 'default' is reserved. (code 26402220): HTTP Response Status:
400 Bad Request HTTP Response Body: {"error":"Package name 'default' is
reserved.","code":26402220}
```
We have to add support for this kind of manifest where package name is set
to `default` and create all entities from the manifest file directly under
namespace. To support this, add a check before creating package, if package
name is set to `default`, skip package creation and reflect it in every entity
creation requests. Instead of sending PUT request to
`namespaces/guest/actions/default/helloNodejs?overwrite=true` send it to
`namespaces/guest/actions/helloNodejs?overwrite=true`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
