[GitHub] rabbah commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions
rabbah commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r174081006 ## File path: core/javaAction/Dockerfile ## @@ -1,38 +1,11 @@ -FROM buildpack-deps:trusty-curl - -ENV DEBIAN_FRONTEND noninteractive - -RUN locale-gen en_US.UTF-8 -ENV LANG en_US.UTF-8 -ENV LANGUAGE en_US:en -ENV LC_ALL en_US.UTF-8 - Review comment: I haven?t looked at the new dockerfile dependence below. If these aren?t set you?ll need to reset them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions
rabbah commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r174080740 ## File path: core/javaAction/Dockerfile ## @@ -1,38 +1,11 @@ -FROM buildpack-deps:trusty-curl - -ENV DEBIAN_FRONTEND noninteractive - -RUN locale-gen en_US.UTF-8 -ENV LANG en_US.UTF-8 -ENV LANGUAGE en_US:en -ENV LC_ALL en_US.UTF-8 - Review comment: You?ll want to restore these. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
