[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389926238 @Himavanth thanks for the thumbs up - will close in favor of new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389755413 @Himavanth take a look at this branch: https://github.com/apache/incubator-openwhisk/compare/master...rabbah:stemcells?expand=1 I rebased this PR to master, resolved conflicts, and made a few changes, organized as separate commits. If you're agreeable, I can open a PR to supersede this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-388403914 @csantanapr this will need a PG. I'll go through it today or this weekend but it's good enough for jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-376820612 Yep. Opinion/feedback/suggestions welcomed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-374462780
Thinking through this a bit more - because it will have breaking changes to
downstream projects, I think we should do the break change once. Let's move the
stem cells to the runtime manifest.
We could do this by adding an additional property for a kind, `stemCells: [
{memory, count} ]` since the kind already specifies the image name. The
invoker's `preWarmConfig` is:
```
case class PrewarmingConfig(count: Int, exec: CodeExec[_], memoryLimit:
ByteSize)
```
so it is sufficient to add the fields I note above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-372168758 Yes. We?d like to get this in for sure. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-370094992 @hsane2001 can you open an issue to discuss the desired feature. I think the approach here establishes a bit of the foundation to do what you like. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363973980 Yes. That was my suggestion above (https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688). We should seperate the multiple cell support into a seperate PR. Here it suffices to export the kind to a pure config setting but make no semantic changes in the invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363974176 We should seperate the multiple cell support into a seperate PR. Here it sufficies to export the kind to a pure config setting but make no semantic changes in the invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363974176 We should seperate the multiple cell support into a seperate PR. Here it sufficies to export the kind to a pure config setting but make no semantic changes in the invoker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363973980 Yes. That was my suggestion above (https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361312490 Thanks for the contribution - do you have an Apache ICLA on file? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
I'm OK with making either of these suggestions separate PRs; as this PR
isn't intended to be semantic changing otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
I'm OK with making that either of these a separate PR as well. As this PR
isn't intended to be semantic changing otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`. Future
additions could also set the default limit for memory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable
rabbah commented on issue #3232: Making prewarm kind (and count) configurable
URL:
https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688
I'd suggest in addition making the configuration a set of stem cells (vs a
single kind). It might look something like this: `prewarm: [{ "kind":
"nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
