[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-16 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-373839436 OK, rebased. This is an automated message from the Apache Git Service. To

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-16 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-373775059 @csantanapr @rabbah and update on this? This is an automated message from the

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-13 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-372843744 I think this should work now; please try again when possible. This is an

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-09 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-371990817 Thanks @rabbah - can you elaborate on "needs a PG"? Will you test deployment on mesos? or just that the dep doesn't drag a bad behavior in with

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-07 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-371325712 @rabbah any comments on this? I have some upcoming changes for a separate/new PR to deal with HA deploy scenarios in mesos, that will make more

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-03-01 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-369687004 @markusthoemmes any other comments here? This is an automated message from the

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-02-28 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-369376482 Thanks @glikson - 1. Marathon has a different notion of lifecycle for containers than openwhisk, so I don't think that using it is a good

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-02-09 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-364574030 @rabbah @markusthoemmes let me know if you have additional comments on this?

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2018-01-23 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-359982636 @markusthoemmes this is ready for another review when you have time This is an

[GitHub] tysonnorris commented on issue #2833: MesosContainerFactory

2017-11-13 Thread GitBox
tysonnorris commented on issue #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#issuecomment-344153860 Review ready. Currently this ContainerFactory does not presume use of any particular logstore, but in general a non-default logstore should be