[jira] [Commented] (ORC-302) Reader: all NULL + isRepeating should NULL out 1st row
[ https://issues.apache.org/jira/browse/ORC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383977#comment-16383977 ] Owen O'Malley commented on ORC-302: --- Ok, what are the desired semantics? I thought the requirement was that: * * if isRepeating is set, only row 0 matters * if !noNulls && isNull[row], then the row is null and the value doesn't matter * Otherwise use the value. Is some part of that understanding wrong? > Reader: all NULL + isRepeating should NULL out 1st row > -- > > Key: ORC-302 > URL: https://issues.apache.org/jira/browse/ORC-302 > Project: ORC > Issue Type: Bug >Affects Versions: 1.4.3, 1.5.0 >Reporter: Gopal V >Priority: Major > > ORC-285 fixed this for Double, but not for other types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ORC-302) Reader: all NULL + isRepeating should NULL out 1st row
[ https://issues.apache.org/jira/browse/ORC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370448#comment-16370448 ] Gopal V commented on ORC-302: - This is about the value vector, not isNull and assumptions about LongColumnVector.NULL_VALUE in Vectorization code written back in 2013. > Reader: all NULL + isRepeating should NULL out 1st row > -- > > Key: ORC-302 > URL: https://issues.apache.org/jira/browse/ORC-302 > Project: ORC > Issue Type: Bug >Affects Versions: 1.4.3, 1.5.0 >Reporter: Gopal V >Priority: Major > > ORC-285 fixed this for Double, but not for other types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ORC-302) Reader: all NULL + isRepeating should NULL out 1st row
[ https://issues.apache.org/jira/browse/ORC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370446#comment-16370446 ] Owen O'Malley commented on ORC-302: --- Can you give me an example Gopal? Do you mean columns that don't have any values? If they have all nulls, it sets the isNull vector correctly. > Reader: all NULL + isRepeating should NULL out 1st row > -- > > Key: ORC-302 > URL: https://issues.apache.org/jira/browse/ORC-302 > Project: ORC > Issue Type: Bug >Affects Versions: 1.4.3, 1.5.0 >Reporter: Gopal V >Priority: Major > > ORC-285 fixed this for Double, but not for other types. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
