Re: [PR] HDDS-12108. Grafana Dashboard for OM CommitIndex [ozone]
venkatsambath commented on PR #7719: URL: https://github.com/apache/ozone/pull/7719#issuecomment-2614504852 Thank you very much for the changes. This is my first jira. Very happy! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-12108. Grafana Dashboard for OM CommitIndex [ozone]
adoroszlai commented on PR #7719: URL: https://github.com/apache/ozone/pull/7719#issuecomment-2610242527 Thanks @venkatsambath for the patch, @kerneltime for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-12108. Grafana Dashboard for OM CommitIndex [ozone]
adoroszlai merged PR #7719: URL: https://github.com/apache/ozone/pull/7719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-12108. Grafana Dashboard for OM CommitIndex [ozone]
kerneltime commented on PR #7719:
URL: https://github.com/apache/ozone/pull/7719#issuecomment-2609429089
> Thank you for this! LGTM, make a change along the following line.
>
> 1. Each follower reports its index
> 2. The leader reports the follower index it knows about.
>
> Thus, the leader reports three values, whereas the follower reports only
one. I would change the legend to something like
>
> ```
> Hostname = {{instance}}, Source OM ID = {{exported_instance}}, Follower OM
ID = {{follower}}
> ```
I pushed the change to your branch. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
Re: [PR] HDDS-12108. Grafana Dashboard for OM CommitIndex [ozone]
kerneltime commented on PR #7719:
URL: https://github.com/apache/ozone/pull/7719#issuecomment-2608793261
Thank you for this! LGTM, make a change along the following line.
1. Each follower reports its index
2. The leader reports the follower index it knows about.
Thus, the leader reports three values, whereas the follower reports only one.
I would change the legend to something like
```
Hostname = {{instance}}, Source OM ID = {{exported_instance}}, Follower OM
ID = {{follower}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
