Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
github-actions[bot] commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3894075442 Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
github-actions[bot] closed pull request #9543: HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt URL: https://github.com/apache/ozone/pull/9543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
github-actions[bot] commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3850359274 This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
szetszwo commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3750805380 > Dependencies of dependencies (including so-called "transitive dependencies") are no different from first-order dependencies ... The above is quoted from https://infra.apache.org/licensing-howto.html#deps-of-deps . It seems that we should just copy the NOTICE file of Ratis-thirdparty. For the dependencies of Ratis-thirdparty, we should also copy their NOTICE files but not adding them to Ratis-thirdparty's NOTICE file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
adoroszlai commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3718469489 > How the bundled dependencies are selected? Why the other bundled dependencies (such as guava) are not selected? I have no idea, but this part of `misc/pom.xml` seems to be responsible for aggregating the NOTICE file: https://github.com/apache/ratis-thirdparty/blob/b644ef7afa23c6ecdb73e2527b5b38df50740d1c/misc/pom.xml#L242-L247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
szetszwo commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3694166983 How the bundled dependencies are selected? Why the other bundled dependencies (such as guava) are not selected? - thirdparty: https://github.com/apache/ratis-thirdparty/blob/1.0.10/pom.xml - misc: https://github.com/apache/ratis-thirdparty/blob/1.0.10/misc/pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt [ozone]
adoroszlai commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3693814495 > is NOTICE-ratis-thirdparty-misc.txt supposed to be the same as https://github.com/apache/ratis-thirdparty/blob/1.0.10/NOTICE ? I guess it should be like NOTICE in `ratis-thirdparty` binary, which contains the `ratis-thirdparty` source NOTICE, and lists bundled dependencies, too: ``` Apache Ratis Thirdparty Miscellaneous Copyright 2017-2025 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). --- This product bundles protobuf-java which includes the following: Copyright 2008 Google Inc. --- This product bundles gRPC which includes the following text: Copyright 2014 The gRPC Authors --- This product bundles Netty which includes the following text: Copyright 2014 The Netty Project --- This product bundles Gson which includes the following text: Copyright 2008 Google Inc. ``` (This is in `misc/target/classes/META-INF/NOTICE` after a build.) Based on that, it LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
