Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
jojochuang merged PR #9622: URL: https://github.com/apache/ozone/pull/9622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
Russole commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3819161955 @jojochuang just a quick follow-up. The update aligning the code and setting ScriptBasedMapping as the default is ready. Happy to address any feedback—thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
jojochuang commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3793802887 Instead, could you update the source code to make it consistent and understandable? https://github.com/apache/ozone/blob/fd8948134efa1e96505d4446d4657f2ad5003396/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L729 https://github.com/apache/ozone/blob/1dda9abfa979f3282d3355e154ce025f76d48665/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L365 update it so the default is ScriptBasedMapping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
Russole commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3755732416 Thanks @jojochuang for pointing this out. Based on the discussion so far, it seems that this PR may no longer be necessary. Please let me know if this PR is still required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
jojochuang commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3750577502 actually according to https://issues.apache.org/jira/browse/HDDS-14385 > The ScriptBasedMapping is used by default for node network location resolve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
Russole commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3739726147 Thanks @sreejasahithi and @sarvekshayr for the review. I’ve updated the patch based on the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
sreejasahithi commented on PR #9622: URL: https://github.com/apache/ozone/pull/9622#issuecomment-3736873907 Thanks @sarvekshayr for identifying the description mismatch , @Russole please update the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-14385. Incorrect net.topology.node.switch.mapping.impl default value [ozone]
sarvekshayr commented on code in PR #9622: URL: https://github.com/apache/ozone/pull/9622#discussion_r2680843107 ## hadoop-hdds/common/src/main/resources/ozone-default.xml: ## Review Comment: Please update the description. ```suggestion The default implementation of the DNSToSwitchMapping. It reads a static mapping file specified in net.topology.table.file.name to resolve node names to network locations. If the value for net.topology.table.file.name is not set, or if a node is not found in the mapping file, the default value of DEFAULT_RACK is returned for all node names. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
