Re: [PR] HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer [ozone]

2026-02-08 Thread via GitHub 


ChenSammi commented on PR #9720:
URL: https://github.com/apache/ozone/pull/9720#issuecomment-3869914319

   Thanks @priyeshkaratha  and @ashishkumar50  for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer [ozone]

2026-02-08 Thread via GitHub 


ChenSammi merged PR #9720:
URL: https://github.com/apache/ozone/pull/9720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer [ozone]

2026-02-08 Thread via GitHub 


ChenSammi commented on code in PR #9720:
URL: https://github.com/apache/ozone/pull/9720#discussion_r2780464332


##
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMDeletedBlockTransactionStatusManager.java:
##
@@ -424,6 +424,14 @@ public void clear() {
 scmDeleteBlocksCommandStatusManager.clear();
 transactionToDNsCommitMap.clear();
 txSizeMap.clear();
+try {
+  initDataDistributionData();

Review Comment:
   Agree. Rename clear() to onBecomeLeader()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer [ozone]

2026-02-06 Thread via GitHub 


ashishkumar50 commented on code in PR #9720:
URL: https://github.com/apache/ozone/pull/9720#discussion_r2772746913


##
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMDeletedBlockTransactionStatusManager.java:
##
@@ -424,6 +424,14 @@ public void clear() {
 scmDeleteBlocksCommandStatusManager.clear();
 transactionToDNsCommitMap.clear();
 txSizeMap.clear();
+try {
+  initDataDistributionData();

Review Comment:
   We can move this code to other method and call when there is leadertransfer 
instead using inside `clear` which is logically meant for clearing all the 
memory maps or alternatively just update the method name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer [ozone]

2026-02-05 Thread via GitHub 


priyeshkaratha commented on code in PR #9720:
URL: https://github.com/apache/ozone/pull/9720#discussion_r2772471712


##
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMDeletedBlockTransactionStatusManager.java:
##
@@ -424,6 +424,14 @@ public void clear() {
 scmDeleteBlocksCommandStatusManager.clear();
 transactionToDNsCommitMap.clear();
 txSizeMap.clear();
+try {
+  initDataDistributionData();
+} catch (IOException e) {
+  LOG.warn("Failed to initialize Storage space distribution data. The 
feature will continue with current " +
+  "totalBlockCount {}, totalBlockCount {}, totalBlocksSize {} and 
totalReplicatedBlocksSize {}. " +
+  "There is a high chance that the real data and current data has 
a fixed gap.",
+  totalBlockCount.get(), totalBlocksSize.get(), totalBlocksSize.get(), 
totalReplicatedBlocksSize.get());

Review Comment:
   ```suggestion
 LOG.warn("Failed to initialize Storage space distribution data. The 
feature will continue with current " +
 "totalBlockCount {}, totalTxCount {}, totalBlocksSize {} and 
totalReplicatedBlocksSize {}. " +
 "There is a high chance that the real data and current data 
has a fixed gap.",
 totalBlockCount.get(), totalTxCount.get(), totalBlocksSize.get(), 
totalReplicatedBlocksSize.get());
   ```



##
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMDeletedBlockTransactionStatusManager.java:
##
@@ -424,6 +424,14 @@ public void clear() {
 scmDeleteBlocksCommandStatusManager.clear();
 transactionToDNsCommitMap.clear();
 txSizeMap.clear();
+try {
+  initDataDistributionData();
+} catch (IOException e) {
+  LOG.warn("Failed to initialize Storage space distribution data. The 
feature will continue with current " +
+  "totalBlockCount {}, totalBlockCount {}, totalBlocksSize {} and 
totalReplicatedBlocksSize {}. " +
+  "There is a high chance that the real data and current data has 
a fixed gap.",
+  totalBlockCount.get(), totalBlocksSize.get(), totalBlocksSize.get(), 
totalReplicatedBlocksSize.get());

Review Comment:
   nit - totalBlocksSize used twice instead of totalTxCount 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]