Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
raulcd closed pull request #3101: GH-3091: Add verification guide and .rat-excludes.txt for release URL: https://github.com/apache/parquet-java/pull/3101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
raulcd commented on PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#issuecomment-2619290534 Finally moved to the arrow-site repo: https://github.com/apache/parquet-site/pull/98 I am closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
Fokko commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1883453208 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: I agree that the `parquet-site` is more suitable for these steps. Regarding the license headers. It is part of the verification; having the `rat` check is just one way. All code must have an ASv2 license header. It would also be good to do manual checks when a new version is being released, as the RAT check might also miss something. Thanks for working on this, this is really great 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
Fokko commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1883453208 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: I agree that the `parquet-site` is more suitable for these steps. Regarding the license headers. It is part of the verification; having the `rat` check is just one way. All code must have an ASv2 license header. It would also be good to do manual checks when a new version is being released, as the RAT check might also miss something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
gszadovszky commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1882719068 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: > How do you perform the comparison between the content of the tarball with a freshly cloned repo set to the release RC tag? Do we want to add that as a step? I use meld as diff tool but I don't think it should be added. Probably GNU `diff` can be configured to work on directory trees. > I will move the PR to the parquet-site one, I might take a couple of days as I am slightly busy at the moment. I don't think we need to hurry. Please refer the `parquet-site` PR here so anyone call follow up. Thanks a lot for working on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
raulcd commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1882419390 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: > I'm not sure why we need to check for the license headers separately in the tarball. It is already in the build process so we shall not have license header issues in the repo. I see, we can probably remove explicitly checking license headers. This is something that in general I've seen all projects do as part of their release verification process and something that I would say falls under the "verify that they meet all requirements of ASF policy on releases as described below" point on the [ASF release guide](https://www.apache.org/legal/release-policy.html#release-approval). But it is true that as soon as there hasn't been any change as those are already done feels unnecessary. How do you perform the comparison between the content of the tarball with a freshly cloned repo set to the release RC tag? Do we want to add that as a step? I will move the PR to the parquet-site one, I might take a couple of days as I am slightly busy at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
gszadovszky commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1882247074 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: I agree the "release verification" should be moved to the `parquet-site` repo instead. Then, we even can have a link to this section in the VOTE email template. I'm not sure why we need to check for the license headers separately in the tarball. It is already in the build process so we shall not have license header issues in the repo. What I usually do instead is comparing the content of the tarball with a freshly cloned repo set to the release RC tag. There should be no differences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
wgtmac commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1880426543 ## dev/README.md: ## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: Thanks for adding this! Is it better to add this to the parquet site: https://github.com/apache/parquet-site/blob/production/content/en/docs/Contribution%20Guidelines/releasing.md? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
wgtmac commented on PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#issuecomment-2536335161 cc @Fokko @gszadovszky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
Re: [PR] GH-3091: Add verification guide and .rat-excludes.txt for release [parquet-java]
raulcd commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1876006229 ## pom.xml: ## @@ -498,6 +498,7 @@ true Review Comment: I am pretty sure we can change `excludes` for `excludesFile` (https://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#excludesFile) but I am unsure why some of the regex on the individual excludes don't seem to work with excludesFile when I ran: `java -jar apache-rat-0.16.1/apache-rat-0.16.1.jar -a -d apache-parquet-1.15.0.tar.gz -E $PARQUET_SRC_FOLDER/.rat-excludes.txt` I'll investigate how to consolidate those two lists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
