[
https://issues.apache.org/jira/browse/PHOENIX-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899810#comment-16899810
]
Hadoop QA commented on PHOENIX-5405:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-5410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899880#comment-16899880
]
Lars Hofhansl edited comment on PHOENIX-5410 at 8/5/19 8:18 AM:
What
[
https://issues.apache.org/jira/browse/PHOENIX-5410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899880#comment-16899880
]
Lars Hofhansl commented on PHOENIX-5410:
What about the 4x branches, should we have that there
[
https://issues.apache.org/jira/browse/PHOENIX-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899927#comment-16899927
]
Chen Feng commented on PHOENIX-5405:
[~lhofhansl] why no test is included? The patch file contains
yanxinyi commented on a change in pull request #558: PHOENIX-5413: Fix union
all error when exists literal column type.
URL: https://github.com/apache/phoenix/pull/558#discussion_r310701796
##
File path:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
[
https://issues.apache.org/jira/browse/PHOENIX-5410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900262#comment-16900262
]
Chinmay Kulkarni commented on PHOENIX-5410:
---
Thanks for adding the fix version [~lhofhansl].
[
https://issues.apache.org/jira/browse/PHOENIX-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900141#comment-16900141
]
James Taylor commented on PHOENIX-5405:
---
I think passing data through a hint is a bad practice.
yanxinyi commented on a change in pull request #558: PHOENIX-5413: Fix union
all error when exists literal column type.
URL: https://github.com/apache/phoenix/pull/558#discussion_r310701796
##
File path:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java
[
https://issues.apache.org/jira/browse/PHOENIX-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900030#comment-16900030
]
Mihir Monani commented on PHOENIX-5327:
---
[~vjasani] Can you check patch if it build locally? It
[
https://issues.apache.org/jira/browse/PHOENIX-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900116#comment-16900116
]
Viraj Jasani commented on PHOENIX-5327:
---
[~mihir6692] I just checked and it seems to be working
[
https://issues.apache.org/jira/browse/PHOENIX-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900391#comment-16900391
]
Geoffrey Jacoby commented on PHOENIX-5426:
--
[~lhofhansl], fyi. (if you can't make the change
swaroopak opened a new pull request #563: PHOENIX-5427: Disable
HttpParamImpersonationQueryServerIT and SecureQ…
URL: https://github.com/apache/phoenix/pull/563
…ueryServerIT
This is an automated message from the Apache Git
ankitjain64 commented on issue #559: PHOENIX-5419: Converting anonymous to
inner class in TracingQueryPlan
URL: https://github.com/apache/phoenix/pull/559#issuecomment-518456988
> @ankitjain64 could you please include the JIRA id PHOENIX-5419 in the
commit header.
@gjacoby126 :
vikashtalanki closed pull request #561: Phoenix 5420 Implement trimb build-in
function for BINARY and VARBINARY
URL: https://github.com/apache/phoenix/pull/561
This is an automated message from the Apache Git Service.
To
swaroopak commented on issue #550: PHOENIX-5348: Fix flaky test:
testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#issuecomment-518431168
@gokceni Let me know when you update this PR.
This is an automated
[
https://issues.apache.org/jira/browse/PHOENIX-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900488#comment-16900488
]
Mehdi Salarkia commented on PHOENIX-5424:
-
[~swaroopa]
Looking at your stack trace it seems
gjacoby126 merged pull request #559: PHOENIX-5419: Converting anonymous to
inner class in TracingQueryPlan
URL: https://github.com/apache/phoenix/pull/559
This is an automated message from the Apache Git Service.
To respond
ChinmaySKulkarni opened a new pull request #564: PHOENIX-5416: Fix Array2IT
testArrayRefToLiteral
URL: https://github.com/apache/phoenix/pull/564
For Arrays of `CHAR` and `BINARY` which are both fixed width and both have
getByteSize() null, we run into an NPE.
With this change,
[
https://issues.apache.org/jira/browse/PHOENIX-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900544#comment-16900544
]
Chinmay Kulkarni commented on PHOENIX-5400:
---
[~swaroopa] Shouldn't this be included as part
gjacoby126 commented on issue #559: PHOENIX-5419: Converting anonymous to inner
class in TracingQueryPlan
URL: https://github.com/apache/phoenix/pull/559#issuecomment-518428197
@ankitjain64 could you please include the JIRA id PHOENIX-5419 in the commit
header.
[
https://issues.apache.org/jira/browse/PHOENIX-5424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900488#comment-16900488
]
Mehdi Salarkia edited comment on PHOENIX-5424 at 8/5/19 11:58 PM:
--
[
https://issues.apache.org/jira/browse/PHOENIX-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900543#comment-16900543
]
Chinmay Kulkarni commented on PHOENIX-5416:
---
[~tdsilva] For Arrays of {{CHAR}} and {{BINARY}}
swaroopak edited a comment on issue #550: PHOENIX-5348: Fix flaky test:
testIndexRebuildTask
URL: https://github.com/apache/phoenix/pull/550#issuecomment-518431168
@gokceni Let me know when you update this PR. Meanwhile, I ll investigate
the failure.
gjacoby126 commented on issue #559: PHOENIX-5419: Converting anonymous to inner
class in TracingQueryPlan
URL: https://github.com/apache/phoenix/pull/559#issuecomment-518462356
@ankitjain64 - for future reference, when you squash your commits into a
single one, please also edit the commit
ChinmaySKulkarni commented on issue #564: PHOENIX-5416: Fix Array2IT
testArrayRefToLiteral
URL: https://github.com/apache/phoenix/pull/564#issuecomment-518470022
Please review @twdsilva @gjacoby126 @dbwong
This is an
[
https://issues.apache.org/jira/browse/PHOENIX-5348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900545#comment-16900545
]
Chinmay Kulkarni commented on PHOENIX-5348:
---
Ping [~giskender] can you please update your
[
https://issues.apache.org/jira/browse/PHOENIX-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900595#comment-16900595
]
Hadoop QA commented on PHOENIX-5416:
{color:red}-1 overall{color}. Here are the results of testing
gjacoby126 commented on issue #564: PHOENIX-5416: Fix Array2IT
testArrayRefToLiteral
URL: https://github.com/apache/phoenix/pull/564#issuecomment-518495931
@ChinmaySKulkarni @twdsilva Should this logic be encapsulated into
LiteralExpression.getMaxLength() itself? Might be cleaner and
[
https://issues.apache.org/jira/browse/PHOENIX-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900650#comment-16900650
]
Hadoop QA commented on PHOENIX-5136:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900597#comment-16900597
]
Hadoop QA commented on PHOENIX-5420:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900596#comment-16900596
]
Hudson commented on PHOENIX-5419:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2877
twdsilva commented on issue #564: PHOENIX-5416: Fix Array2IT
testArrayRefToLiteral
URL: https://github.com/apache/phoenix/pull/564#issuecomment-518493331
+1 , LGTM.
This is an automated message from the Apache Git Service.
32 matches
Mail list logo
