[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015567#comment-17015567 ] Swaroopa Kadam edited comment on PHOENIX-5644 at 1/15/20 2:42 AM: -- Since the patch didn't apply cleanly on the master, submitting new one for master. was (Author: swaroopa): Since the patch didn't apply cleanly on the master, submitting new one. > IndexUpgradeTool should sleep only once if there is at least one immutable > table provided > - > > Key: PHOENIX-5644 > URL: https://issues.apache.org/jira/browse/PHOENIX-5644 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.0, 4.15.1, 4.14.4, 4.16.0 > > Attachments: PHOENIX-5644.4.x-HBase-1.3.add.patch, > PHOENIX-5644.4.x-HBase-1.3.add.v1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv2.patch, PHOENIX-5644.4.x-HBase-1.3.patch, > PHOENIX-5644.4.x-HBase-1.3.v1.patch, PHOENIX-5644.4.x-HBase-1.3.v2.patch, > PHOENIX-5644.4.x-HBase-1.3.v3.patch, PHOENIX-5644.master.add.patch, > PHOENIX-5644.v1.patch > > Time Spent: 6h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015331#comment-17015331 ] Lars Hofhansl edited comment on PHOENIX-5644 at 1/14/20 7:20 PM: - Hmm... I would agree. (Although we should not have any flappers anymore - it might have been a followup failure, which is exactly why it's not good to have tests broken). If you're sure that this fixes the timeout issue, go ahead to commit... +1 was (Author: lhofhansl): Hmm... I would agree. (Although we should not have any flappers anymore). If you're sure that this fixes the timeout issue, go ahead to commit... +1 > IndexUpgradeTool should sleep only once if there is at least one immutable > table provided > - > > Key: PHOENIX-5644 > URL: https://issues.apache.org/jira/browse/PHOENIX-5644 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.0, 4.15.1, 4.14.4, 4.16.0 > > Attachments: PHOENIX-5644.4.x-HBase-1.3.add.patch, > PHOENIX-5644.4.x-HBase-1.3.add.v1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv2.patch, PHOENIX-5644.4.x-HBase-1.3.patch, > PHOENIX-5644.4.x-HBase-1.3.v1.patch, PHOENIX-5644.4.x-HBase-1.3.v2.patch, > PHOENIX-5644.4.x-HBase-1.3.v3.patch, PHOENIX-5644.v1.patch > > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014721#comment-17014721 ] Swaroopa Kadam edited comment on PHOENIX-5644 at 1/13/20 11:17 PM: --- I already have a fix for the test. Lets not revert it please. Waiting for the build to run on my patch. Thank you for your patience. was (Author: swaroopa): I already have a fix for the test. Lets not revert it please. > IndexUpgradeTool should sleep only once if there is at least one immutable > table provided > - > > Key: PHOENIX-5644 > URL: https://issues.apache.org/jira/browse/PHOENIX-5644 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.0, 4.15.1, 4.14.4, 4.16.0 > > Attachments: PHOENIX-5644.4.x-HBase-1.3.add.patch, > PHOENIX-5644.4.x-HBase-1.3.add.v1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv1.patch, PHOENIX-5644.4.x-HBase-1.3.patch, > PHOENIX-5644.4.x-HBase-1.3.v1.patch, PHOENIX-5644.4.x-HBase-1.3.v2.patch, > PHOENIX-5644.4.x-HBase-1.3.v3.patch, PHOENIX-5644.v1.patch > > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014714#comment-17014714 ] Lars Hofhansl edited comment on PHOENIX-5644 at 1/13/20 10:56 PM: -- That was the test-run actually... Let me just revert this change, please. Then we can re-apply together with the passing (and performing) tests. Edit: Oh you're saying it couldn't have been 13h since you added the patch more recently? I certainly can't fault that logic :) What do you want to do? Revert the whole thing and re-apply, or continue to try to come with a test-fix quickly. was (Author: lhofhansl): That was the test-run actually... Let me just revert this change, please. Then we can re-apply together with the passing (and performing) tests. > IndexUpgradeTool should sleep only once if there is at least one immutable > table provided > - > > Key: PHOENIX-5644 > URL: https://issues.apache.org/jira/browse/PHOENIX-5644 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.0, 4.15.1, 4.14.4, 4.16.0 > > Attachments: PHOENIX-5644.4.x-HBase-1.3.add.patch, > PHOENIX-5644.4.x-HBase-1.3.add.v1.patch, > PHOENIX-5644.4.x-HBase-1.3.addv1.patch, PHOENIX-5644.4.x-HBase-1.3.patch, > PHOENIX-5644.4.x-HBase-1.3.v1.patch, PHOENIX-5644.4.x-HBase-1.3.v2.patch, > PHOENIX-5644.4.x-HBase-1.3.v3.patch, PHOENIX-5644.v1.patch > > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
