[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909333#comment-16909333 ] Xinyi Yan commented on PHOENIX-5420: [~vikashtalanki] I don't have a good answer here. Instead of running a single test, running all tests? > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907890#comment-16907890 ] Vikash Talanki commented on PHOENIX-5420: - [~yanxinyi], The exception related to functional test is the one I was referring in the above comments. The functional tests ran successfully in my local. When I create a patch and upload, the hadoop QA runs throw org.apache.phoenix.exception.UndecodableByteException. I am unable to debug this as its not failing in my local. > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907684#comment-16907684 ] Xinyi Yan commented on PHOENIX-5420: I just checked build UI and found your build [https://builds.apache.org/job/PreCommit-PHOENIX-Build/2910/console] with an error message as following: Client error: Notify your administrator that Bob Swift Atlassian Apps - Jira Command Line Interface (CLI) requires a valid license. Reason: VERSION_MISMATCH Above message is not related to your changes; however, you do have a functional test failed with an error message as following. Please fix your test while I'm waiting for the response from Apache Infra, thanks. [ERROR] testTrimDoubleByteChar(org.apache.phoenix.expression.TrimbFunctionTest) Time elapsed: 0.033 s <<< ERROR! org.apache.phoenix.exception.UndecodableByteException: Undecodable byte: -1 at org.apache.phoenix.expression.TrimbFunctionTest.testTrimbExpression(TrimbFunctionTest.java:104) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimb(TrimbFunctionTest.java:115) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimDoubleByteChar(TrimbFunctionTest.java:67) [ERROR] testTrimDoubleByteChar(org.apache.phoenix.expression.TrimbFunctionTest) Time elapsed: 0.045 s <<< ERROR! org.apache.phoenix.exception.UndecodableByteException: Undecodable byte: -1 at org.apache.phoenix.expression.TrimbFunctionTest.testTrimbExpression(TrimbFunctionTest.java:104) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimb(TrimbFunctionTest.java:115) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimDoubleByteChar(TrimbFunctionTest.java:67) [ERROR] testTrimDoubleByteChar(org.apache.phoenix.expression.TrimbFunctionTest) Time elapsed: 0.036 s <<< ERROR! org.apache.phoenix.exception.UndecodableByteException: Undecodable byte: -1 at org.apache.phoenix.expression.TrimbFunctionTest.testTrimbExpression(TrimbFunctionTest.java:104) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimb(TrimbFunctionTest.java:115) at org.apache.phoenix.expression.TrimbFunctionTest.testTrimDoubleByteChar(TrimbFunctionTest.java:67) > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907624#comment-16907624 ] Xinyi Yan commented on PHOENIX-5420: I mean Hadoop QA sending report. > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907621#comment-16907621 ] Xinyi Yan commented on PHOENIX-5420: I think we have heading QA not sending report problem. I also submitted my patch and didn’t get report for a day. I went to check the Jenkins build web UI, and I found my patch did run but got error as following: Client error: Notify your administrator that Bob Swift Atlassian Apps - Jira Command Line Interface (CLI) requires a valid license. Reason: VERSION_MISMATCH. As as a result, I sent an email to the [u...@infra.apache.org|mailto:u...@infra.apache.org] and asked about this issue. FYI [~elserj] > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907616#comment-16907616 ] Vikash Talanki commented on PHOENIX-5420: - [~yanxinyi], I resubmitted the patch. Please look into any failures after QA tests run. > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906623#comment-16906623 ] Xinyi Yan commented on PHOENIX-5420: [~vikashtalanki] I guess Jenkins doesn't keep your changes anymore. If you think your tests past locally, please re-submit your patch again and I will take a look after. Thank you for the patch@! > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[ https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905760#comment-16905760 ] Vikash Talanki commented on PHOENIX-5420: - Hi Xinyi, I have written IT and function tests and ran them in my local. All the tests ran without any errors. However, after creating the patch and uploading it in this JIRA , the Hadoop QA automated run says that there is a failure in one of the function tests as you can see above. I have created a new branch and applied the patch that I uploaded and ran the tests again, and I see there are no issues/errors. Not able to debug why automated runs are failing. Can you please help me out in this. !https://ssl.gstatic.com/ui/v1/icons/mail/images/cleardot.gif! > Implement trimb built-in function for BINARY and VARBINARY > -- > > Key: PHOENIX-5420 > URL: https://issues.apache.org/jira/browse/PHOENIX-5420 > Project: Phoenix > Issue Type: Sub-task >Reporter: Vikash Talanki >Assignee: Vikash Talanki >Priority: Major > Labels: beginner, features, newbie, patch > Attachments: PHOENIX-5420.master.v4.patch > > > see https://issues.apache.org/jira/browse/PHOENIX-2158 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PHOENIX-5420) Implement trimb built-in function for BINARY and VARBINARY
[
https://issues.apache.org/jira/browse/PHOENIX-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900597#comment-16900597
]
Hadoop QA commented on PHOENIX-5420:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12976778/PHOENIX-5420.master.v4.patch
against master branch at commit e3d3ae5b120189235259280fc074bc7f337aa5b3.
ATTACHMENT ID: 12976778
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.expression.TrimbFunctionTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2879//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2879//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2879//console
This message is automatically generated.
> Implement trimb built-in function for BINARY and VARBINARY
> --
>
> Key: PHOENIX-5420
> URL: https://issues.apache.org/jira/browse/PHOENIX-5420
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Vikash Talanki
>Assignee: Vikash Talanki
>Priority: Major
> Labels: beginner, features, newbie, patch
> Attachments: PHOENIX-5420.master.v4.patch
>
>
> see https://issues.apache.org/jira/browse/PHOENIX-2158
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
