[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-13 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014691#comment-17014691
 ] 

Hudson commented on PHOENIX-5628:
-

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3279 (See 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3279/])
PHOENIX-5628 Phoenix Function to Return HBase Row Key of Column Cell (abhishek: 
rev 87f2cecf2405fd6050b003e55249ae5672319fe1)
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RowKeyBytesStringFunction.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowKeyBytesStringFunctionIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java


> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-13 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014213#comment-17014213
 ] 

Hudson commented on PHOENIX-5628:
-

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #362 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/362/])
PHOENIX-5628 Phoenix Function to Return HBase Row Key of Column Cell (abhishek: 
rev a60cb5a18c3d31ae767d0a3b7c44482f1707366a)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowKeyBytesStringFunctionIT.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RowKeyBytesStringFunction.java


> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-13 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014203#comment-17014203
 ] 

Hudson commented on PHOENIX-5628:
-

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #242 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.5/242/])
PHOENIX-5628 Phoenix Function to Return HBase Row Key of Column Cell (abhishek: 
rev 458f252a9781f5d1ba174a5a60fef867d4dc7a09)
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowKeyBytesStringFunctionIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RowKeyBytesStringFunction.java


> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-12 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013944#comment-17013944
 ] 

Hudson commented on PHOENIX-5628:
-

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #644 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/644/])
PHOENIX-5628 Phoenix Function to Return HBase Row Key of Column Cell (abhishek: 
rev 1b5b5eedaafacc355e05a5995d9292be6569892e)
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/RowKeyBytesStringFunction.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java
* (add) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowKeyBytesStringFunctionIT.java


> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-12 Thread Abhishek Singh Chouhan (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013942#comment-17013942
 ] 

Abhishek Singh Chouhan commented on PHOENIX-5628:
-

Pushed to 4.x and master. Thanks for the review [~gjacoby]!

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013371#comment-17013371
 ] 

Hadoop QA commented on PHOENIX-5628:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12990624/PHOENIX-5628-master.001.patch
  against master branch at commit 97755237a41a806bf6fec3df6aca182f06d123cb.
  ATTACHMENT ID: 12990624

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
++ " (id, pkcol, page_id, \"DATE\", \"value\") VALUES 
(1, 'a', 8, 1," + values[0] + ")");
++ " (id, pkcol, page_id, \"DATE\", \"value\") VALUES (2, 
'ab', 8, 2," + values[1] + ")");
++ " (id, pkcol, page_id, \"DATE\", \"value\") VALUES (3, 
'abc', 8, 3," + values[2] + ")");
++ " (id, pkcol, page_id, \"DATE\", \"value\") VALUES (5, 
'abcde', 8, 5," + values[4] + ")");
++ " (id, pkcol, page_id, \"DATE\", \"value\") VALUES (4, 
'abcd', 8, 4," + values[3] + ")");
+conn.createStatement().executeQuery("SELECT 
ROWKEY_BYTES_STRING() FROM " + tableName);
+
assertTrue(Bytes.equals(hbaseRes.getValue(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
 Bytes.toBytes("value")), 

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3275//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3275//console

This message is automatically generated.

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Abhishek Singh Chouhan (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013354#comment-17013354
 ] 

Abhishek Singh Chouhan commented on PHOENIX-5628:
-

somehow qa didnt pick it up, reattaching the patch.

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.001.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Geoffrey Jacoby (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013309#comment-17013309
 ] 

Geoffrey Jacoby commented on PHOENIX-5628:
--

+1, thanks [~abhishek.chouhan]

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Abhishek Singh Chouhan (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013305#comment-17013305
 ] 

Abhishek Singh Chouhan commented on PHOENIX-5628:
-

Changed the function name to be "ROWKEY_BYTES_STRING" so as avoid confusion of 
it being a function to get the exact byte[] of the rowkey, but rather as 
[~gjacoby] mentioned just the pretty printed version of it.

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.001.patch, PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Geoffrey Jacoby (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013302#comment-17013302
 ] 

Geoffrey Jacoby commented on PHOENIX-5628:
--

[~an...@apache.org] - I filed this JIRA for the (somewhat narrow, I admit) case 
where you need to get a row key in a "pretty-printed" format suitable for use 
in the HBase shell. Having a similar varbinary function could be useful for 
other reasons, but that seems to me a separate JIRA. 

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Daniel Wong (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013261#comment-17013261
 ] 

Daniel Wong commented on PHOENIX-5628:
--

I agree with the above please add composite key with variable types, and 
sorting.  The HBase check is valid but perhaps overkill we can simply define 
the rowkey and compare against it.

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Ankit Singhal (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013219#comment-17013219
 ] 

Ankit Singhal commented on PHOENIX-5628:


[~abhishek.chouhan], when you have a composite key, the string version of 
rowkey will not make much sense. so it is better to have return type as 
VARBINARY instead to be VARCHAR.

{code}
+@Override
+public boolean evaluate(Tuple tuple, ImmutableBytesWritable ptr) {
+tuple.getKey(ptr);
+String rowkey = Bytes.toStringBinary(ptr.get(), ptr.getOffset(), 
ptr.getLength());
+ptr.set(PVarchar.INSTANCE.toBytes(rowkey));
+return true;
+}
+
+@Override
+public PDataType getDataType() {
+return PVarchar.INSTANCE;
+}
{code}

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Priyank Porwal (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013204#comment-17013204
 ] 

Priyank Porwal commented on PHOENIX-5628:
-

[~abhishek.chouhan] Nicely done. Thank you! If you are going to add new tests, 
might I suggest adding additional PK column.

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Priyank Porwal (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013183#comment-17013183
 ] 

Priyank Porwal commented on PHOENIX-5628:
-

[~gjacoby] - Wrt isStatelesss() - 
[https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java#L70-L76]

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Geoffrey Jacoby (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013133#comment-17013133
 ] 

Geoffrey Jacoby commented on PHOENIX-5628:
--

Generally looks good, [~abhishek.chouhan]. Would be good to have at least one 
assertion in the test case that a particular row byte array maps to a 
particular row in HBase, not just any row. 

Also, just for my information, what does isStateless mean in this context? 
Haven't ever added a fn myself and I don't see a comment explaining it in the 
base class. 

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PHOENIX-5628) Phoenix Function to Return HBase Row Key of Column Cell

2020-01-10 Thread Abhishek Singh Chouhan (Jira)


[ 
https://issues.apache.org/jira/browse/PHOENIX-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013112#comment-17013112
 ] 

Abhishek Singh Chouhan commented on PHOENIX-5628:
-

Attached the patches to 5629 earlier by mistake, qa should pick these up now. 
[~gjacoby]

> Phoenix Function to Return HBase Row Key of Column Cell
> ---
>
> Key: PHOENIX-5628
> URL: https://issues.apache.org/jira/browse/PHOENIX-5628
> Project: Phoenix
>  Issue Type: New Feature
>Reporter: Geoffrey Jacoby
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5628-4.x-HBase-1.5.patch, 
> PHOENIX-5628-master.patch
>
>
> It's occasionally useful when diagnosing an issue with Phoenix to be able to 
> easily look up the byte array of a row key that corresponds to a cell with a 
> Phoenix query. This can then be looked up in the HBase shell. 
> For example:
> SELECT ROWKEY_BYTES(Column1) FROM Table1 WHERE Column1 = 'SomeValue'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)