jbonofre commented on code in PR #183:
URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2902109384
##
iceberg-catalog-migrator/cli/BUNDLE-LICENSE:
##
@@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat.
Project URL: https://tomcat.apache.org/
License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+This artifact bundles Google FindBugs JSR305 annotations.
+
+Project URL: http://findbugs.sourceforge.net/
+License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+
+This artifact bundles Mortbay Jetty 6.1.26.
Review Comment:
We can remove the version here.
I checked and the other Mortbay classes (util, etc) are from Jetty as well.
##
iceberg-catalog-migrator/cli/BUNDLE-LICENSE:
##
@@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat.
Project URL: https://tomcat.apache.org/
License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+This artifact bundles Google FindBugs JSR305 annotations.
+
+Project URL: http://findbugs.sourceforge.net/
+License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+
+This artifact bundles Mortbay Jetty 6.1.26.
+
+Project URL: http://www.mortbay.org/jetty/
+License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+
+This artifact bundles cglib.
Review Comment:
cglib is coming from Guice and it should be documented indeed.
The `NOTICE` file should contain the cglib `NOTICE`:
https://github.com/cglib/cglib/blob/master/NOTICE
However, cglib `NOTICE` content is already covered, so our `NOTICE` is fine.
##
iceberg-catalog-migrator/cli/BUNDLE-LICENSE:
##
@@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat.
Project URL: https://tomcat.apache.org/
License: Apache License, Version 2.0 -
http://www.apache.org/licenses/LICENSE-2.0.txt
+
+
+This artifact bundles Google FindBugs JSR305 annotations.
Review Comment:
We don't have to document findbugs JSR305 here because there's no classes
from findbugs bundled in the jar (only pom):
```
META-INF/maven/com.google.code.findbugs/jsr305/pom.xml
META-INF/maven/com.google.code.findbugs/jsr305/pom.properties
META-INF/maven/com.google.code.findbugs/jsr305/
META-INF/maven/com.google.code.findbugs/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
