Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
flyingImer commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2927303140 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Love your discussions ❤️! I think there are two different topics here. For this PR, I’d prefer to keep the scope narrow and human-facing: the submitting human remains accountable, must understand the change, and AI tools are not contributors. Questions like reviewer burden, generated-code header treatment, or contributions from AI-controlled GitHub accounts feel real, but broader. My bias is that those belong in a separate discussion rather than in this `CONTRIBUTING.md` update. So I’d prefer to keep this PR focused on human contributor accountability and spin the broader agent/harness questions out separately. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
jbonofre commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926738169 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Let's remove AI, let's talk about code generating code (like OpenAPI): we don't include header here because the code is generated. So, if we consider the code as generated by AI, ASF header should not be added. If the contributor, review and/or modify the code, then yes ASF header is possible. If the tool (AI or other) set copyright (usually not), then it has to be kept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
dimas-b commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926555802 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Re: ASF header: It says `Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements`. If we can assume that the contributor did due diligence per https://www.apache.org/legal/generative-tooling.html and ensured that the generated code is not copyrightable by another entity, I suppose using the ASF header should be fine :thinking: Of course, if there is other copyright on the generated code, then the appropriate header should be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
jbonofre commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926504517 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Maybe we should ask to put a header like: ``` /** * This code has been generated by AI Foo Model */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
jbonofre commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926504517 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Maybe we should ask to put a header like: ``` This code has been generated by AI Foo Model ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
jbonofre commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926499554 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Something important also to remember is that we can't have copyright on generated source (AI or other tool). So ASF header should not be added on a class where the majority of the code is generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
dimas-b commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926281524 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: That applies to all PRs, IMHO :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
flyrain commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926412543 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: it is, however, generated code tends to cover more things than manually written code, which make the situation worse. Also an explicit rule make it clear that keeping PRs smaller are prefereed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
flyrain commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2926138922 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Given that AI generated code and PRs put a lot of burden on the reviewers. Should we add something like ``` Authors must ensure that AI assisted pull requests remain focused, well explained, and of a size that can be reasonably reviewed by humans. Submissions that significantly increase reviewer burden may be asked to be reduced in scope or revised before review. ``` ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. Review Comment: Given that AI generated code and PRs put a lot of burden on the reviewers. Should we add something like Authors must ensure that AI assisted pull requests remain focused, well explained, and of a size that can be reasonably reviewed by humans. Submissions that significantly increase reviewer burden may be asked to be reduced in scope or revised before review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
dimas-b commented on PR #3948: URL: https://github.com/apache/polaris/pull/3948#issuecomment-4048506829 @jbonofre : wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
flyingImer commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2921611299 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. +* **Respect ASF policy**. Ensure generated content does not introduce incompatible licenses or undisclosed third-party code; review the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) and licensing rules when in doubt. Review Comment: love it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [DRAFT] doc: introduce guidelines for AI-generated contributions [polaris]
dimas-b commented on code in PR #3948: URL: https://github.com/apache/polaris/pull/3948#discussion_r2906486850 ## CONTRIBUTING.md: ## @@ -119,6 +119,16 @@ Tips: * Keep in mind that the Git commit subject and message is going to be read by other people, potentially even after years. The Git commit subject and message will appear "as is" in release notes. * Make sure the subject and message are properly formatted and contains a concise description of the changes in way that someone who has no prior knowledge can understand the rationale of the change and the change itself. Remove information that's of no use for someone reading the Git commit log, for example single intermediate commit messages like `formatting` or `fix test`. + Guidelines for AI-assisted Contributions + +Contributors may use a variety of tools when preparing changes to Polaris, including AI systems (e.g., large language models or code assistants). Contributors using such systems are expected to adhere to the following principles: + +* Regardless of how a change is produced, the individual submitting the pull request is considered the author of the contribution and is fully responsible for it. +* The pull request author **must understand the implementation end-to-end** and be able to **explain and justify the design and code** during review. +* Tools, including AI systems, **are not** considered contributors. **Responsibility and authorship remain with the human** submitting the change. +* Contributors are encouraged to **disclose** significant AI assistance in the pull request description for transparency. +* **Respect ASF policy**. Ensure generated content does not introduce incompatible licenses or undisclosed third-party code; review the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) and licensing rules when in doubt. Review Comment: `does not introduce incompatible licenses` seems a bit vague IMHO. How about `the author is responsible for ensuring that the generated code can be contributed to Polaris under the ASF license and the Generative Tooling policy ...`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
