Re: [PR] Add Polaris-Generic-Table-Access-Delegation header in the Generic Table API spec for credential vending [polaris]
gh-yzou merged PR #4043: URL: https://github.com/apache/polaris/pull/4043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Polaris-Generic-Table-Access-Delegation header in the Generic Table API spec for credential vending [polaris]
gh-yzou commented on PR #4043: URL: https://github.com/apache/polaris/pull/4043#issuecomment-4145272041 Nothing changed, run ./gradlew spotlessApply to fix a format issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Polaris-Generic-Table-Access-Delegation header in the Generic Table API spec for credential vending [polaris]
gh-yzou commented on code in PR #4043: URL: https://github.com/apache/polaris/pull/4043#discussion_r2990896245 ## spec/polaris-catalog-apis/generic-tables-api.yaml: ## @@ -182,6 +186,26 @@ components: type: string example: "sales" +polaris-generic-table-data-access: + name: Polaris-Generic-Table-Access-Delegation + in: header + description: > +Optional header indicating that the client supports delegated access +using a specific mechanism. If the header is present, the server must +either provide access using the requested mechanism or fail the request. + + Review Comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Polaris-Generic-Table-Access-Delegation header in the Generic Table API spec for credential vending [polaris]
flyrain commented on PR #4043: URL: https://github.com/apache/polaris/pull/4043#issuecomment-4129513244 looks like this failed all PRs' CI ``` #4 [internal] load metadata for docker.io/apache/spark:3.5.6-java17-python3 #4 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 500 Internal Server Error: an unknown error occurred during the request -- > [internal] load metadata for docker.io/apache/spark:3.5.6-java17-python3: -- Dockerfile:20 18 | # 19 | 20 | >>> FROM docker.io/apache/spark:3.5.6-java17-python3 21 | 22 | ARG POLARIS_HOST=polaris failed to solve: docker.io/apache/spark:3.5.6-java17-python3: failed to resolve source metadata for docker.io/apache/spark:3.5.6-java17-python3: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 500 Internal Server Error: an unknown error occurred during the request ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Polaris-Generic-Table-Access-Delegation header in the Generic Table API spec for credential vending [polaris]
dimas-b commented on code in PR #4043: URL: https://github.com/apache/polaris/pull/4043#discussion_r2990359712 ## spec/polaris-catalog-apis/generic-tables-api.yaml: ## @@ -182,6 +186,26 @@ components: type: string example: "sales" +polaris-generic-table-data-access: + name: Polaris-Generic-Table-Access-Delegation + in: header + description: > +Optional header indicating that the client supports delegated access +using a specific mechanism. If the header is present, the server must +either provide access using the requested mechanism or fail the request. + + Review Comment: nit: two empty lines? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
