Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
ajantha-bhat merged PR #183: URL: https://github.com/apache/polaris-tools/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on PR #183: URL: https://github.com/apache/polaris-tools/pull/183#issuecomment-4065005508 @ajantha-bhat on it right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
ajantha-bhat commented on PR #183: URL: https://github.com/apache/polaris-tools/pull/183#issuecomment-4064495907 ping @jbonofre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
ajantha-bhat commented on PR #183: URL: https://github.com/apache/polaris-tools/pull/183#issuecomment-4028924887 @jbonofre: Let me know if you have any more comments on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
ajantha-bhat commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906239140 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: Agree that it should be separate. I have pushed a new change now. PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906228912 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: @RussellSpitzer oh yeah, I remember now. Sorry I was confused. My bad. So, then yeah, definitely we have to keep jsr305. Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
RussellSpitzer commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906218146 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: @jbonofre They are separate, they are not the same. This is a weird historical quirk where jsr305 was assigned that space (javax.annotation) but then the JSR305 became dormant and was never merged. **So citing javax.annotation-api does not cover these annotations, they do not exist in javax.annotation-api.** They only exist in the jsr305 dependency" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
RussellSpitzer commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906218146 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: @jbonofre They are separate, they are not the same. This is a weird historical quirk where jsr305 was assigned that space (javax.annotation) but then the JSR305 became dormant and was never merged. **So citing javax.annotation-api does not cover these annotations, they do not exist in javax.annotation-api. They only exist in the jsr305 dependency" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906171595 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: I would suggest to use both javax.annotation-api and jsr305 (not just javax.annotation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906168285 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: We already document `javax.annotation` in the `LICENSE`. So we have to clarify in the `LICENSE`: either use jsr305 or javax.annotation in the `LICENSE` for clarity. That's my point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
RussellSpitzer commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906149087 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: I'm not quite sure how this licensing is supposed to work, but here is the analysis ```bash cd /tmp/polaris-rc-verify && DISTJAR=iceberg-catalog-migrator-cli-1.0.0.jar echo "=== Classes that are ONLY in jsr305 (not in javax.annotation-api) ===" echo "jsr305 provides nullability/concurrency annotations." echo "javax.annotation-api provides Java EE lifecycle annotations." echo "" echo "--- jsr305-specific classes (nullability): ---" jar tf "$DISTJAR" | rg "^javax/annotation/" | rg "Nonnull|Nullable|CheckFor|Tainted|Untainted|Signed|Detainted|ParametersAre|WillClose|WillNot|PropertyKey|RegEx|Syntax|OverridingMethods|Nonnegative|MatchesPattern" echo "" echo "--- jsr305-specific classes (concurrency): ---" jar tf "$DISTJAR" | rg "^javax/annotation/concurrent/" echo "" echo "--- jsr305-specific classes (meta): ---" jar tf "$DISTJAR" | rg "^javax/annotation/meta/" echo "" echo "--- javax.annotation-api classes (Java EE): ---" jar tf "$DISTJAR" | rg "^javax/annotation/" | rg "Generated|ManagedBean|PostConstruct|PreDestroy|Priority|Resource|security/|sql/" ``` ``` === Classes that are ONLY in jsr305 (not in javax.annotation-api) === jsr305 provides nullability/concurrency annotations. javax.annotation-api provides Java EE lifecycle annotations. --- jsr305-specific classes (nullability): --- javax/annotation/CheckForNull.class javax/annotation/CheckForSigned.class javax/annotation/Detainted.class javax/annotation/MatchesPattern$Checker.class javax/annotation/MatchesPattern.class javax/annotation/Nonnegative$Checker.class javax/annotation/Nonnegative.class javax/annotation/Nonnull$Checker.class javax/annotation/Nonnull.class javax/annotation/Nullable.class javax/annotation/OverridingMethodsMustInvokeSuper.class javax/annotation/ParametersAreNonnullByDefault.class javax/annotation/ParametersAreNullableByDefault.class javax/annotation/PropertyKey.class javax/annotation/RegEx$Checker.class javax/annotation/RegEx.class javax/annotation/Signed.class javax/annotation/Syntax.class javax/annotation/Tainted.class javax/annotation/Untainted.class javax/annotation/WillClose.class javax/annotation/WillCloseWhenClosed.class javax/annotation/WillNotClose.class --- jsr305-specific classes (concurrency): --- javax/annotation/concurrent/GuardedBy.class javax/annotation/concurrent/Immutable.class javax/annotation/concurrent/NotThreadSafe.class javax/annotation/concurrent/ThreadSafe.class javax/annotation/concurrent/ --- jsr305-specific classes (meta): --- javax/annotation/meta/Exclusive.class javax/annotation/meta/Exhaustive.class javax/annotation/meta/TypeQualifier.class javax/annotation/meta/TypeQualifierDefault.class javax/annotation/meta/TypeQualifierNickname.class javax/annotation/meta/TypeQualifierValidator.class javax/annotation/meta/When.class javax/annotation/meta/ --- javax.annotation-api classes (Java EE): --- javax/annotation/Generated.class javax/annotation/ManagedBean.class javax/annotation/PostConstruct.class javax/annotation/PreDestroy.class javax/annotation/Priority.class javax/annotation/Resource$AuthenticationType.class javax/annotation/Resource.class javax/annotation/Resources.class javax/annotation/security/DeclareRoles.class javax/annotation/security/DenyAll.class javax/annotation/security/PermitAll.class javax/annotation/security/RolesAllowed.class javax/annotation/security/RunAs.class javax/annotation/security/package.html javax/annotation/sql/DataSourceDefinition.class javax/annotation/sql/DataSourceDefinitions.class javax/annotation/Generated.class javax/annotation/ManagedBean.class javax/annotation/PostConstruct.class javax/annotation/PreDestroy.class javax/annotation/Priority.class javax/annotation/Resource$AuthenticationType.class javax/annotation/Resource.class javax/annotation/Resources.class javax/annotation/security/DeclareRoles.class javax/annotation/security/DenyAll.class javax/annotation/security/PermitAll.class javax/annotation/security/RolesAllowed.class javax/annotation/security/RunAs.class javax/annotation/sql/DataSourceDefinition.class javax/annotation/sql/DataSourceDefinitions.class javax/annotation/security/ javax/annotation/sql/ ``` -- Th
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
RussellSpitzer commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906129300 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: The belong to jsr305 but are in a different package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906135093 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: I don't see it in the artifact either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
RussellSpitzer commented on code in PR #183: URL: https://github.com/apache/polaris-tools/pull/183#discussion_r2906127162 ## iceberg-catalog-migrator/cli/BUNDLE-LICENSE: ## @@ -1344,4 +1344,25 @@ This artifact bundles Apache Tomcat. Project URL: https://tomcat.apache.org/ License: Apache License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + + +This artifact bundles Google FindBugs JSR305 annotations. Review Comment: No we include a bunch of annotation classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Catalog Migrator: Fix LICENSE & NOTICE typos and add missing entires [polaris-tools]
jbonofre commented on PR #183: URL: https://github.com/apache/polaris-tools/pull/183#issuecomment-4021690585 > @jbonofre and @RussellSpitzer: I have updated the PR as per latest comments. Please take another look. @ajantha-bhat thanks, I will do a new pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
