Re: [PR] Guides: compose dependencies / long-option [polaris]
snazy commented on code in PR #3611: URL: https://github.com/apache/polaris/pull/3611#discussion_r2749279286 ## getting-started/telemetry/docker-compose.yml: ## @@ -78,6 +78,8 @@ services: depends_on: polaris: condition: service_healthy + polaris-setup: +condition: service_completed_successfully Review Comment: Actually, it's [not strictly needed in the other PR for the telemetry guide](https://github.com/apache/polaris/pull/3612#discussion_r2749270997), but I've added it for consistency across the guides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guides: compose dependencies / long-option [polaris]
snazy commented on code in PR #3611: URL: https://github.com/apache/polaris/pull/3611#discussion_r2749275023 ## getting-started/telemetry/docker-compose.yml: ## @@ -78,6 +78,8 @@ services: depends_on: polaris: condition: service_healthy + polaris-setup: +condition: service_completed_successfully Review Comment: Good point! I'll adjust the other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guides: compose dependencies / long-option [polaris]
snazy merged PR #3611: URL: https://github.com/apache/polaris/pull/3611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Guides: compose dependencies / long-option [polaris]
MonkeyCanCode commented on code in PR #3611: URL: https://github.com/apache/polaris/pull/3611#discussion_r2748026849 ## getting-started/telemetry/docker-compose.yml: ## @@ -78,6 +78,8 @@ services: depends_on: polaris: condition: service_healthy + polaris-setup: +condition: service_completed_successfully Review Comment: As we are changing to tail forever on the other PR, we will need to change this to service_healthy instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
