[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436230#comment-16436230
]
Hadoop QA commented on RATIS-219:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435260#comment-16435260
]
Tsz Wo Nicholas Sze commented on RATIS-219:
---
+1 the 003 patch looks good.
> Add configuration
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435170#comment-16435170
]
Lokesh Jain commented on RATIS-219:
---
[~szetszwo] Thanks for reviewing the patch! v3 patch addresses your
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434610#comment-16434610
]
Hadoop QA commented on RATIS-219:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434375#comment-16434375
]
Tsz Wo Nicholas Sze commented on RATIS-219:
---
Thanks. Some nites
- requestTimeoutDuration in
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431114#comment-16431114
]
Hadoop QA commented on RATIS-219:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430973#comment-16430973
]
Tsz Wo Nicholas Sze commented on RATIS-219:
---
One quick comment:
- In GRpcLogAppender, read the