[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437540#comment-16437540
]
Tsz Wo Nicholas Sze commented on RATIS-225:
---
+1 the 003 patch looks good.
> Grpc LogAppender
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436972#comment-16436972
]
Lokesh Jain commented on RATIS-225:
---
The match index is updated in the heartbeat only if previous append
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436732#comment-16436732
]
Lokesh Jain commented on RATIS-225:
---
[~szetszwo] v2 patch adds a test. GrpcLogAppender can not use
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435367#comment-16435367
]
Lokesh Jain commented on RATIS-225:
---
This can happen during normal operation as well. Suppose the
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435316#comment-16435316
]
Tsz Wo Nicholas Sze commented on RATIS-225:
---
> ... This happens because append entry reply might
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435239#comment-16435239
]
Lokesh Jain commented on RATIS-225:
---
LogAppender#onSuccess might throw IllegalStateException in case of
[
https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430357#comment-16430357
]
Lokesh Jain commented on RATIS-225:
---
The v1 patch modifies the test for appendEntryTimeout to test the
