[jira] [Commented] (RATIS-47) Shade google guava and combine ratis-netty-shaded with ratis-proto-shaded

2017-03-21 Thread Tsz Wo Nicholas Sze (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935638#comment-15935638
 ] 

Tsz Wo Nicholas Sze commented on RATIS-47:
--

Have you manually deleted the source before shade?
{code}
rm -rf ratis-proto-shaded/src/main/java
rm -rf ratis-hadoop-shaded/src/main/java
{code}

> Shade google guava and combine ratis-netty-shaded with ratis-proto-shaded
> -
>
> Key: RATIS-47
> URL: https://issues.apache.org/jira/browse/RATIS-47
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Fix For: 0.1
>
> Attachments: r47_20170317.patch, r47_20170320.patch
>
>
> Even we do not use google guava internally, gRPC still depends on it.  
> Therefore, we need to shade it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-47) Shade google guava and combine ratis-netty-shaded with ratis-proto-shaded

2017-03-21 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935636#comment-15935636
 ] 

Enis Soztutar commented on RATIS-47:


I am getting compilation errors in the recent code base. Is it only me? 
{code}
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 39.252s
[INFO] Finished at: Tue Mar 21 18:44:12 PDT 2017
[INFO] Final Memory: 49M/553M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on 
project ratis-hadoop: Compilation failure: Compilation failure:
[ERROR] 
/Users/enis/projects/git-repos/ratis/ratis-hadoop/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngineShaded.java:[38,86]
 package 
org.apache.ratis.shaded.org.apache.hadoop.ipc.protobuf.ProtobufRpcEngineProtos 
does not exist
[ERROR] 
/Users/enis/projects/git-repos/ratis/ratis-hadoop/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngineShaded.java:[39,78]
 package org.apache.ratis.shaded.org.apache.hadoop.ipc.protobuf.RpcHeaderProtos 
does not exist
[ERROR] 
/Users/enis/projects/git-repos/ratis/ratis-hadoop/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngineShaded.java:[40,78]
 package org.apache.ratis.shaded.org.apache.hadoop.ipc.protobuf.RpcHeaderProtos 
does not exist
[ERROR] 
/Users/enis/projects/git-repos/ratis/ratis-hadoop/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngineShaded.java:[142,13]
 cannot find symbol
{code}

> Shade google guava and combine ratis-netty-shaded with ratis-proto-shaded
> -
>
> Key: RATIS-47
> URL: https://issues.apache.org/jira/browse/RATIS-47
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Fix For: 0.1
>
> Attachments: r47_20170317.patch, r47_20170320.patch
>
>
> Even we do not use google guava internally, gRPC still depends on it.  
> Therefore, we need to shade it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)