[jira] [Commented] (RATIS-631) Propagate state machine's last applied index from follower to leader

2020-01-23 Thread Tsz-wo Sze (Jira) 


[ 
https://issues.apache.org/jira/browse/RATIS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021932#comment-17021932
 ] 

Tsz-wo Sze commented on RATIS-631:
--

Let's make the changes together since the patch here is not big.  Sound good?

> Propagate state machine's last applied index from follower to leader
> 
>
> Key: RATIS-631
> URL: https://issues.apache.org/jira/browse/RATIS-631
> Project: Ratis
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
>  Labels: ozone
> Attachments: RATIS-631.001.patch
>
>
> State Machine's last applied index denotes the index till which the 
> transactions have been successfully applied by the state machine. This index 
> needs to be propagated from the follower to leader in order for leader to 
> determine by how many transactions follower's state machine is lagging behind.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RATIS-631) Propagate state machine's last applied index from follower to leader

2020-01-23 Thread Lokesh Jain (Jira) 


[ 
https://issues.apache.org/jira/browse/RATIS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021870#comment-17021870
 ] 

Lokesh Jain commented on RATIS-631:
---

This will be stored in FollowerInfo of log appender. The plan is to compare 
stateMachineAppliedIndex of peers and fail client requests if peers lag in 
stateMachineAppliedIndex. This would be similar to RATIS-632.

> Propagate state machine's last applied index from follower to leader
> 
>
> Key: RATIS-631
> URL: https://issues.apache.org/jira/browse/RATIS-631
> Project: Ratis
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
>  Labels: ozone
> Attachments: RATIS-631.001.patch
>
>
> State Machine's last applied index denotes the index till which the 
> transactions have been successfully applied by the state machine. This index 
> needs to be propagated from the follower to leader in order for leader to 
> determine by how many transactions follower's state machine is lagging behind.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RATIS-631) Propagate state machine's last applied index from follower to leader

2020-01-22 Thread Tsz-wo Sze (Jira) 


[ 
https://issues.apache.org/jira/browse/RATIS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021805#comment-17021805
 ] 

Tsz-wo Sze commented on RATIS-631:
--

The  last applied index is not used in the patch.  What is the plan?

> Propagate state machine's last applied index from follower to leader
> 
>
> Key: RATIS-631
> URL: https://issues.apache.org/jira/browse/RATIS-631
> Project: Ratis
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
>  Labels: ozone
> Attachments: RATIS-631.001.patch
>
>
> State Machine's last applied index denotes the index till which the 
> transactions have been successfully applied by the state machine. This index 
> needs to be propagated from the follower to leader in order for leader to 
> determine by how many transactions follower's state machine is lagging behind.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (RATIS-631) Propagate state machine's last applied index from follower to leader

2020-01-14 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/RATIS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015063#comment-17015063
 ] 

Hadoop QA commented on RATIS-631:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m  8s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m  4s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
|   | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-14 |
| JIRA Issue | RATIS-631 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12990835/RATIS-631.001.patch |
| Optional Tests |  dupname  asflicense  cc  unit  javac  javadoc  findbugs  
checkstyle  compile  |
| uname | Linux 656ff89a2b60 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 9954074 |
| maven | version: Apache Maven 3.6.3 
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1206/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1206/testReport/ |
| Max. process+thread count | 1777 (vs. ulimit of 5000) |
| modules | C: ratis-proto ratis-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1206/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Propagate state machine's last applied ind