[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[ https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027299#comment-17027299 ] Lokesh Jain commented on RATIS-755: --- [~msingh] Thanks for the updating the patch! The changes look good to me. +1. > Add a log dump command line utility inside ratis > > > Key: RATIS-755 > URL: https://issues.apache.org/jira/browse/RATIS-755 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Fix For: 0.5.0 > > Attachments: RATIS-755.001.patch, RATIS-755.002.patch, > RATIS-755.003.patch, RATIS-755.004.patch, RATIS-755.005.patch, > RATIS-755.006.patch > > > This tool proposes to add a utility to dump the following information to the > a) log index > b) log term > c) log entry type > d) state machine data if present -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026837#comment-17026837
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
58s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
13s{color} | {color:green} root generated 0 new + 30 unchanged - 1 fixed = 30
total (was 31) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 14s{color} | {color:orange} root: The patch generated 1 new + 6 unchanged -
1 fixed = 7 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 9s{color}
| {color:red} root in the patch failed. {color} |
| {color:blue}0{color} | {color:blue} asflicense {color} | {color:blue} 0m
21s{color} | {color:blue} ASF License check generated no output? {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.grpc.TestLogAppenderWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.raftlog.segmented.TestSegmentedRaftLog |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestRaftExceptionWithGrpc |
| | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-30 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12992248/RATIS-755.006.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux 7ec47c12d1b9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 38d55c4 |
| maven | version: Apache Maven 3.6.3
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/1228/artifact/out/diff-checkstyle-root.txt
|
| unit |
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[ https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026796#comment-17026796 ] Mukul Kumar Singh commented on RATIS-755: - Thanks for the review [~ljain]. patch v6 fixes the issue. > Add a log dump command line utility inside ratis > > > Key: RATIS-755 > URL: https://issues.apache.org/jira/browse/RATIS-755 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Fix For: 0.5.0 > > Attachments: RATIS-755.001.patch, RATIS-755.002.patch, > RATIS-755.003.patch, RATIS-755.004.patch, RATIS-755.005.patch, > RATIS-755.006.patch > > > This tool proposes to add a utility to dump the following information to the > a) log index > b) log term > c) log entry type > d) state machine data if present -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[ https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026576#comment-17026576 ] Lokesh Jain commented on RATIS-755: --- [~msingh] There is a failure in TestCacheEviction related to mock of LogSegment class. Can you please look into it? > Add a log dump command line utility inside ratis > > > Key: RATIS-755 > URL: https://issues.apache.org/jira/browse/RATIS-755 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Fix For: 0.5.0 > > Attachments: RATIS-755.001.patch, RATIS-755.002.patch, > RATIS-755.003.patch, RATIS-755.004.patch, RATIS-755.005.patch > > > This tool proposes to add a utility to dump the following information to the > a) log index > b) log term > c) log entry type > d) state machine data if present -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026085#comment-17026085
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
16s{color} | {color:green} root generated 0 new + 30 unchanged - 1 fixed = 30
total (was 31) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} root: The patch generated 0 new + 6 unchanged - 1
fixed = 6 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 12s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.server.raftlog.segmented.TestCacheEviction |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.grpc.TestLogAppenderWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.grpc.TestRetryCacheWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-29 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12992149/RATIS-755.005.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux 48717b6c98fb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026038#comment-17026038
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} root generated 0 new + 30 unchanged - 1 fixed = 30
total (was 31) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 12s{color} | {color:orange} root: The patch generated 3 new + 6 unchanged -
1 fixed = 9 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 23s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.server.raftlog.segmented.TestCacheEviction |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-29 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12992144/RATIS-755.004.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux f5b9174ad389 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build@2/yetus-personality.sh
|
| git revision | master / 1ccfa66 |
| maven | version: Apache Maven 3.6.3
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/1225/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCom
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026034#comment-17026034
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
48s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} root generated 0 new + 30 unchanged - 1 fixed = 30
total (was 31) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} root: The patch generated 3 new + 6 unchanged -
1 fixed = 9 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 36m 50s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
| | ratis.grpc.TestStateMachineShutdownWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.raftlog.segmented.TestCacheEviction |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-29 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12992143/RATIS-755.003.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux 5edd8349dc1d 4.15.0-74-generic #84-Ubuntu SMP Thu
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[ https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025909#comment-17025909 ] Lokesh Jain commented on RATIS-755: --- [~msingh] Thanks for updating the patch! The changes look good to me. There are a few checkstyle issues. +1 o.w. > Add a log dump command line utility inside ratis > > > Key: RATIS-755 > URL: https://issues.apache.org/jira/browse/RATIS-755 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Fix For: 0.5.0 > > Attachments: RATIS-755.001.patch, RATIS-755.002.patch > > > This tool proposes to add a utility to dump the following information to the > a) log index > b) log term > c) log entry type > d) state machine data if present -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025773#comment-17025773
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 54s{color}
| {color:red} root generated 1 new + 30 unchanged - 1 fixed = 31 total (was 31)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 11s{color} | {color:orange} root: The patch generated 9 new + 6 unchanged -
1 fixed = 15 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 34m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.netty.TestRaftWithNetty |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-29 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12992094/RATIS-755.002.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux dfba71c63a90 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 1ccfa66 |
| maven | version: Apache Maven 3.6.3
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| ja
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021109#comment-17021109
]
Hadoop QA commented on RATIS-755:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 54s{color}
| {color:red} root generated 1 new + 30 unchanged - 1 fixed = 31 total (was 31)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} root: The patch generated 7 new + 6 unchanged -
1 fixed = 13 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 28m 38s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-22 |
| JIRA Issue | RATIS-755 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12990849/RATIS-755.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
findbugs checkstyle |
| uname | Linux 8da85b6f53a0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 9954074 |
| maven | version: Apache Maven 3.6.3
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| javac |
https
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020453#comment-17020453
]
Mukul Kumar Singh commented on RATIS-755:
-
Thanks for the review [~ljain],if the StateMachineFunction is not provided
then, there wont be any SM string part.
basically in the above output there wont be any "State Machine: " lines.
{code}
+String smString = "";
+if (function != null) {
+ smString = "\n\t State Machine: " + function.apply(smLog);
+}
+return callIdString + smString;
{code}
> Add a log dump command line utility inside ratis
>
>
> Key: RATIS-755
> URL: https://issues.apache.org/jira/browse/RATIS-755
> Project: Ratis
> Issue Type: Bug
>Affects Versions: 0.4.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Labels: ozone
> Fix For: 0.5.0
>
> Attachments: RATIS-755.001.patch
>
>
> This tool proposes to add a utility to dump the following information to the
> a) log index
> b) log term
> c) log entry type
> d) state machine data if present
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[ https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020376#comment-17020376 ] Lokesh Jain commented on RATIS-755: --- [~msingh] Thanks for working on this! The changes look good to me. Just a suggestion: We can add a simple utility which prints basic info irrespective of state machine type. We can do it as part of separate Jira though. > Add a log dump command line utility inside ratis > > > Key: RATIS-755 > URL: https://issues.apache.org/jira/browse/RATIS-755 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Fix For: 0.5.0 > > Attachments: RATIS-755.001.patch > > > This tool proposes to add a utility to dump the following information to the > a) log index > b) log term > c) log entry type > d) state machine data if present -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-755) Add a log dump command line utility inside ratis
[
https://issues.apache.org/jira/browse/RATIS-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015000#comment-17015000
]
Mukul Kumar Singh commented on RATIS-755:
-
The log dump with this utility is like
{code}
20178:ratis2 mukul$ java -jar
ratis-tools/target/ratis-tools-0.5.0-SNAPSHOT-shaded.jar
/tmp/arithmetic/64656d6f-5261-6674-4772-6f7570313233/current/log_inprogress_0
file path is
/tmp/arithmetic/64656d6f-5261-6674-4772-6f7570313233/current/log_inprogress_0
(t:1, i:0), CONFIGURATIONENTRY
(t:1, i:1), STATEMACHINELOGENTRY, client-6143FC438F2B, cid=0
State Machine: a = 3
(t:1, i:2), METADATAENTRY(c1)
(t:1, i:3), STATEMACHINELOGENTRY, client-FBF7EA69AB2A, cid=0
State Machine: b = 4
(t:1, i:4), METADATAENTRY(c3)
{code}
> Add a log dump command line utility inside ratis
>
>
> Key: RATIS-755
> URL: https://issues.apache.org/jira/browse/RATIS-755
> Project: Ratis
> Issue Type: Bug
>Affects Versions: 0.4.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Labels: ozone
> Fix For: 0.5.0
>
> Attachments: RATIS-755.001.patch
>
>
> This tool proposes to add a utility to dump the following information to the
> a) log index
> b) log term
> c) log entry type
> d) state machine data if present
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
