[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116147#comment-16116147 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 +1 > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > Fix For: 4.2.0-incubating > > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974137#comment-15974137 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @zhouxinyu @shroman @vongosling what's your advice guys? > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968788#comment-15968788 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968789#comment-15968789 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968787#comment-15968787 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11085065) Coverage increased (+2.8%) to 34.601% when pulling **6647aebcac672c4a40c6855629769083f7b4110c on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968564#comment-15968564 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/11083601) Coverage increased (+2.8%) to 34.628% when pulling **4449b2b21bc9aa198f88a5cdaeb68cd91b112cda on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968557#comment-15968557
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111524822
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.utils;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URL;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.LoggerFactory;
+
+public class LogUtils {
+
+/**
+ * config logback dymatically from provided file path, otherwise try
to config from resource file
+ * @param logConfigFilePath specified logback configuration file path
+ * @param logbackResourceFile specified logback configuration resource
file, which will only be respected when logConfigFilePath is null
+ * @param iLoggerFactory
+ * @throws ClassNotFoundException
+ * @throws InstantiationException
+ * @throws IllegalAccessException
+ * @throws NoSuchMethodException
+ * @throws InvocationTargetException
+ */
+public static void configLogback(String logConfigFilePath, String
logbackResourceFile, ILoggerFactory iLoggerFactory) throws
ClassNotFoundException, InstantiationException, IllegalAccessException,
NoSuchMethodException, InvocationTargetException {
+Class joranConfigurator;
+Class context = Class.forName("ch.qos.logback.core.Context");
+Object joranConfiguratoroObj;
+joranConfigurator =
Class.forName("ch.qos.logback.classic.joran.JoranConfigurator");
+joranConfiguratoroObj = joranConfigurator.newInstance();
+Method setContext =
joranConfiguratoroObj.getClass().getMethod("setContext", context);
+setContext.invoke(joranConfiguratoroObj, iLoggerFactory);
+if (null == logConfigFilePath) {
+if (logbackResourceFile != null) {
+URL url =
LogUtils.class.getClassLoader().getResource(logbackResourceFile);
+Method doConfigure =
joranConfiguratoroObj.getClass().getMethod("doConfigure", URL.class);
+doConfigure.invoke(joranConfiguratoroObj, url);
+}
+} else {
+Method doConfigure =
joranConfiguratoroObj.getClass().getMethod("doConfigure", String.class);
+doConfigure.invoke(joranConfiguratoroObj, logConfigFilePath);
+}
+}
+
+/**
+ * config log4j dymatically from provided file path, otherwise try to
config from resource file. Notice that the log4j configuration file should be
in xml format
--- End diff --
Fixed, thank you!
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966245#comment-15966245
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r111210164
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.utils;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URL;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.LoggerFactory;
+
+public class LogUtils {
+
+/**
+ * config logback dymatically from provided file path, otherwise try
to config from resource file
--- End diff --
Thank you! I will update the commit soon.
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965972#comment-15965972 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 +1 > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965969#comment-15965969
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67855
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.utils;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URL;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.LoggerFactory;
+
+public class LogUtils {
+
+/**
+ * config logback dymatically from provided file path, otherwise try
to config from resource file
+ * @param logConfigFilePath specified logback configuration file path
+ * @param logbackResourceFile specified logback configuration resource
file, which will only be respected when logConfigFilePath is null
+ * @param iLoggerFactory
+ * @throws ClassNotFoundException
+ * @throws InstantiationException
+ * @throws IllegalAccessException
+ * @throws NoSuchMethodException
+ * @throws InvocationTargetException
+ */
+public static void configLogback(String logConfigFilePath, String
logbackResourceFile, ILoggerFactory iLoggerFactory) throws
ClassNotFoundException, InstantiationException, IllegalAccessException,
NoSuchMethodException, InvocationTargetException {
+Class joranConfigurator;
+Class context = Class.forName("ch.qos.logback.core.Context");
+Object joranConfiguratoroObj;
+joranConfigurator =
Class.forName("ch.qos.logback.classic.joran.JoranConfigurator");
+joranConfiguratoroObj = joranConfigurator.newInstance();
+Method setContext =
joranConfiguratoroObj.getClass().getMethod("setContext", context);
+setContext.invoke(joranConfiguratoroObj, iLoggerFactory);
+if (null == logConfigFilePath) {
+if (logbackResourceFile != null) {
+URL url =
LogUtils.class.getClassLoader().getResource(logbackResourceFile);
+Method doConfigure =
joranConfiguratoroObj.getClass().getMethod("doConfigure", URL.class);
+doConfigure.invoke(joranConfiguratoroObj, url);
+}
+} else {
+Method doConfigure =
joranConfiguratoroObj.getClass().getMethod("doConfigure", String.class);
+doConfigure.invoke(joranConfiguratoroObj, logConfigFilePath);
+}
+}
+
+/**
+ * config log4j dymatically from provided file path, otherwise try to
config from resource file. Notice that the log4j configuration file should be
in xml format
--- End diff --
dymatically same as above.
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965968#comment-15965968
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r67737
--- Diff:
common/src/main/java/org/apache/rocketmq/common/utils/LogUtils.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common.utils;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.net.URL;
+import org.slf4j.ILoggerFactory;
+import org.slf4j.LoggerFactory;
+
+public class LogUtils {
+
+/**
+ * config logback dymatically from provided file path, otherwise try
to config from resource file
--- End diff --
Typo here: dymatically --> dynamically
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947121#comment-15947121 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10827873) Coverage increased (+0.008%) to 31.788% when pulling **980c1a3b9b2ea054cdbba34d11fac31532a2ec7e on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947120#comment-15947120 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10827873) Coverage increased (+0.008%) to 31.788% when pulling **980c1a3b9b2ea054cdbba34d11fac31532a2ec7e on Jaskey:ROCKETMQ-158** into **ab013861cd488f535d9cc03c21481922ba21ed9d on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947073#comment-15947073 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui please review the updated pr, log4j_tools.xml has been move to distributions. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947051#comment-15947051
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108666872
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -196,22 +196,11 @@ private static void initLog() {
ILoggerFactory iLoggerFactory =
LoggerFactory.getILoggerFactory();
Class classType = iLoggerFactory.getClass();
if
(classType.getName().equals("org.slf4j.impl.Log4jLoggerFactory")) {
-Class domconfigurator;
-Object domconfiguratorobj;
-domconfigurator =
Class.forName("org.apache.log4j.xml.DOMConfigurator");
-domconfiguratorobj = domconfigurator.newInstance();
-Method configure =
domconfiguratorobj.getClass().getMethod("configure", String.class);
-configure.invoke(domconfiguratorobj, rocketmqHome +
"/conf/log4j_tools.xml");
+final String logfjConfigPath = rocketmqHome +
"/conf/log4j_tools.xml";
+LogUtils.configLog4j(logfjConfigPath,null);
} else if
(classType.getName().equals("ch.qos.logback.classic.LoggerContext")) {
-Class joranConfigurator;
--- End diff --
@vongosling the updated pr has been extract two logger config into util
function. Do you mean the if else code snippet is need to wrap too?
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946717#comment-15946717
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108616049
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -196,22 +196,11 @@ private static void initLog() {
ILoggerFactory iLoggerFactory =
LoggerFactory.getILoggerFactory();
Class classType = iLoggerFactory.getClass();
if
(classType.getName().equals("org.slf4j.impl.Log4jLoggerFactory")) {
-Class domconfigurator;
-Object domconfiguratorobj;
-domconfigurator =
Class.forName("org.apache.log4j.xml.DOMConfigurator");
-domconfiguratorobj = domconfigurator.newInstance();
-Method configure =
domconfiguratorobj.getClass().getMethod("configure", String.class);
-configure.invoke(domconfiguratorobj, rocketmqHome +
"/conf/log4j_tools.xml");
+final String logfjConfigPath = rocketmqHome +
"/conf/log4j_tools.xml";
+LogUtils.configLog4j(logfjConfigPath,null);
} else if
(classType.getName().equals("ch.qos.logback.classic.LoggerContext")) {
-Class joranConfigurator;
--- End diff --
Yes, we may wrap here further @Jaskey
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[
https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946703#comment-15946703
]
ASF GitHub Bot commented on ROCKETMQ-158:
-
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/85#discussion_r108614905
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java ---
@@ -196,22 +196,11 @@ private static void initLog() {
ILoggerFactory iLoggerFactory =
LoggerFactory.getILoggerFactory();
Class classType = iLoggerFactory.getClass();
if
(classType.getName().equals("org.slf4j.impl.Log4jLoggerFactory")) {
-Class domconfigurator;
-Object domconfiguratorobj;
-domconfigurator =
Class.forName("org.apache.log4j.xml.DOMConfigurator");
-domconfiguratorobj = domconfigurator.newInstance();
-Method configure =
domconfiguratorobj.getClass().getMethod("configure", String.class);
-configure.invoke(domconfiguratorobj, rocketmqHome +
"/conf/log4j_tools.xml");
+final String logfjConfigPath = rocketmqHome +
"/conf/log4j_tools.xml";
+LogUtils.configLog4j(logfjConfigPath,null);
} else if
(classType.getName().equals("ch.qos.logback.classic.LoggerContext")) {
-Class joranConfigurator;
--- End diff --
Could we extract this log loader logic into one place
> Remove logback dependency for rocketmq-tools
>
>
> Key: ROCKETMQ-158
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-158
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-tools
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
>
> Since user may need to use some admin interfaces to maintain something like
> create topic, manage queues.
> They will need to use rocketmq-tools which contains DefaultMQAdminExt.
> But rocketmq-tools has explicitly depend on logback-classic and logback-core,
> which may be conflict with the logging framework of the user's application.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946695#comment-15946695 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 The conf folder has been moved to the distribution module, please rebase this PR on top of develop branch. I'll +1 thereafter. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946618#comment-15946618 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui please review the updated pr > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946495#comment-15946495 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10821765) Coverage decreased (-0.08%) to 31.791% when pulling **3d3801b09e23fbb8af546df1803a0da34a63727e on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946443#comment-15946443 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 > So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. Changing specific dependency to a neutral logging framework is good to have as application developer may integrate tool module to their operation management system. > But actually it is a little different from the clientLogger since clientlogger will use the resources file in the classpath by default while tools admin does not have config file in the classpath. I know this, but it does not look like a blocking issue. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946433#comment-15946433 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 @lizhanhui So do you agree this is indeed an issue that needed to be solved? If yes, I will try doing that. But actually it is a little different from the clientLogger since clientlogger will use the resources file in the classpath by default while tools admin does not have config file in the classpath. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945415#comment-15945415 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 The logic here shares much similar logic with ClientLogger class, can we extract the common part into a reusable method? > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945142#comment-15945142 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945143#comment-15945143 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945141#comment-15945141 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807947) Coverage decreased (-0.04%) to 31.829% when pulling **b7218ae4333be8d553f8c00386c241b5ee049e2a on Jaskey:ROCKETMQ-158** into **7e37799e822cda30b0607f859fc5574f468a49f3 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945032#comment-15945032 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945030#comment-15945030 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945031#comment-15945031 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10807112) Coverage increased (+0.04%) to 31.662% when pulling **53bb2a63828a44a2b2e3ab34e6a7e598d0c22fba on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945020#comment-15945020 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling **b5876bb5651693c12b4774cebe722f0202155331 on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945021#comment-15945021 ] ASF GitHub Bot commented on ROCKETMQ-158: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/85 [](https://coveralls.io/builds/10806993) Coverage increased (+0.03%) to 31.644% when pulling **b5876bb5651693c12b4774cebe722f0202155331 on Jaskey:ROCKETMQ-158** into **203cb30a906a77f41b0e5ba09fc351434862d408 on apache:develop**. > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-158) Remove logback dependency for rocketmq-tools
[ https://issues.apache.org/jira/browse/ROCKETMQ-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944932#comment-15944932 ] ASF GitHub Bot commented on ROCKETMQ-158: - GitHub user Jaskey opened a pull request: https://github.com/apache/incubator-rocketmq/pull/85 [ROCKETMQ-158]Remove logback dependency for rocketmq-tools jira: https://issues.apache.org/jira/browse/ROCKETMQ-158 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-158 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/85.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #85 commit 97e0ead4e1ad5c06d19d5ea55afca7396f1db929 Author: Jaskey Date: 2017-03-28T10:51:16Z [ROCKETMQ-158]Remove logback dependency for rocketmq-tools > Remove logback dependency for rocketmq-tools > > > Key: ROCKETMQ-158 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-158 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-tools >Reporter: Jaskey Lam >Assignee: Jaskey Lam >Priority: Minor > > Since user may need to use some admin interfaces to maintain something like > create topic, manage queues. > They will need to use rocketmq-tools which contains DefaultMQAdminExt. > But rocketmq-tools has explicitly depend on logback-classic and logback-core, > which may be conflict with the logging framework of the user's application. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
