[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140013#comment-16140013 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 @evthoriz Thanks, looking forward to your patch :-) > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139981#comment-16139981 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user evthoriz commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 @shroman @vongosling It seems that plenty of tests are associated with this modification, I will resubmit a patch when I complete the relevant integration test. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122796#comment-16122796 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 [](https://coveralls.io/builds/12789603) Coverage increased (+0.2%) to 38.926% when pulling **f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122795#comment-16122795 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 [](https://coveralls.io/builds/12789603) Coverage increased (+0.2%) to 38.926% when pulling **f7b7b5b1d8b7536f69504fd9bbe68d2511d8865f on evthoriz:develop-my** into **98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121264#comment-16121264 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 @evthoriz we usually need some measure to verify our correction, no matter what you do. IMO, unit test is a effective practice when we coding. Looking forward to hear from you again :-) > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101439#comment-16101439 ] Yu Kaiyuan commented on ROCKETMQ-248: - [~Jaskey] I think the usage of `consumeFromWhere ` is to let the consumers determine where they wants to start consuming from. And the behavior of the option should match the expectation. In the very situation of a new scaled queue of an *existing topic & existing subscription*, consumer should apparently consume from the beginning of the new scaled queue to avoid message loss. And the patch already takes it into consideration. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101302#comment-16101302 ] Jaskey Lam commented on ROCKETMQ-248: - Indeed, it will not work when the queue is newly created. This is to issue the problem that when grabing a brand new queue fof one single client instance , if it is a new queue, insist on consuming from the last may skip some messages. As far as I am concerned, this is the only scene which may not be working as expected, while this scene should be treated very carefully. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096071#comment-16096071 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 [](https://coveralls.io/builds/12490822) Coverage decreased (-0.3%) to 38.442% when pulling **827ca7584b62cc8b6e5aa5b06b3b3e6fd56c88bc on evthoriz:develop-my** into **118bdec96005ce695295bcf0d9082e0230e69bf7 on apache:develop**. > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096062#comment-16096062 ] ASF GitHub Bot commented on ROCKETMQ-248: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/132 @evthoriz Thank you. Do you have a test for this? > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ROCKETMQ-248) ConsumeFromWhere does not always work as expected
[ https://issues.apache.org/jira/browse/ROCKETMQ-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095975#comment-16095975 ] ASF GitHub Bot commented on ROCKETMQ-248: - GitHub user evthoriz opened a pull request: https://github.com/apache/incubator-rocketmq/pull/132 [ROCKETMQ-248] make ConsumeFromWhere work right JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-248 You can merge this pull request into a Git repository by running: $ git pull https://github.com/evthoriz/incubator-rocketmq develop-my Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit 827ca7584b62cc8b6e5aa5b06b3b3e6fd56c88bc Author: Kaiyuan Yu Date: 2017-07-21T08:13:27Z make ConsumeFromWhere work right > ConsumeFromWhere does not always work as expected > - > > Key: ROCKETMQ-248 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-248 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-broker, rocketmq-client >Affects Versions: 4.0.0-incubating, 4.1.0-incubating >Reporter: Yu Kaiyuan >Assignee: yukon > > As a *brand new subscription*, consumer will be allowed to decide where to > start the consumption. And the options includes: > * CONSUME_FROM_LAST_OFFSET > * CONSUME_FROM_FIRST_OFFSET > * CONSUME_FROM_TIMESTAMP > But the fact is the option: `CONSUME_FROM_LAST_OFFSET` does not always work > as expected. Even if the subscription is new, the consumer still might > consume from the first message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
