[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122982#comment-16122982
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user lindzh closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/141


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122977#comment-16122977
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user lollipopjin commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  
Thanks @lindzh. I have merged it, please close this pr :-)


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122959#comment-16122959
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12790961/badge)](https://coveralls.io/builds/12790961)

Coverage decreased (-0.6%) to 38.989% when pulling 
**0afab06e67404871cbd52f904c70c1a2a9e80876 on lindzh:logger_appender_test** 
into **bcc65e5471d9821e0edb90f6f637e3034ed1da44 on apache:develop**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122957#comment-16122957
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12790961/badge)](https://coveralls.io/builds/12790961)

Coverage decreased (-0.6%) to 38.989% when pulling 
**0afab06e67404871cbd52f904c70c1a2a9e80876 on lindzh:logger_appender_test** 
into **bcc65e5471d9821e0edb90f6f637e3034ed1da44 on apache:develop**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121605#comment-16121605
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12777678/badge)](https://coveralls.io/builds/12777678)

Coverage decreased (-0.4%) to 38.728% when pulling 
**9b5dfd8c0dbbaec8a1ba46e3d9171fd90bea262a on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121268#comment-16121268
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12774185/badge)](https://coveralls.io/builds/12774185)

Coverage decreased (-0.5%) to 38.622% when pulling 
**ee2e2cdb01c3711504215c6f3b55a5e9223dbd42 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121269#comment-16121269
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12774185/badge)](https://coveralls.io/builds/12774185)

Coverage decreased (-0.5%) to 38.622% when pulling 
**ee2e2cdb01c3711504215c6f3b55a5e9223dbd42 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116142#comment-16116142
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  
LGTM


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108638#comment-16108638
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108639#comment-16108639
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108640#comment-16108640
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108424#comment-16108424
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/141#discussion_r130525133
  
--- Diff: 
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
 ---
@@ -61,7 +68,7 @@ public static MQProducer getInstance(String 
nameServerAddress, String group) thr
 defaultMQProducer.setNamesrvAddr(nameServerAddress);
 MQProducer beforeProducer = null;
 //cas put producer
--- End diff --

what's the purpose for this comment :-)


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107103#comment-16107103
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12619313/badge)](https://coveralls.io/builds/12619313)

Coverage decreased (-0.5%) to 38.602% when pulling 
**42075612f2f103c2df54475e93c8ebfb5d6de133 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107102#comment-16107102
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12619313/badge)](https://coveralls.io/builds/12619313)

Coverage decreased (-0.5%) to 38.602% when pulling 
**42075612f2f103c2df54475e93c8ebfb5d6de133 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107075#comment-16107075
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

GitHub user lindzh opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/141

[ROCKETMQ-254] fix logger appender unit test too long with mock

LoggerAppender unit test cost much time, and in some cases it may cause 
test failure,fix this case this mockito.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindzh/incubator-rocketmq logger_appender_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit 42075612f2f103c2df54475e93c8ebfb5d6de133
Author: lindzh 
Date:   2017-07-31T09:58:27Z

fix logger appender unit test too long with mock




> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)