[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188078084 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188077621 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188077808 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188077732 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188076059 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64JSWrapper.as ## @@ -0,0 +1,44 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188076212 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188076829 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188076000 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/TextEncoderLiteWrapper.as ## @@ -0,0 +1,46 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188077020 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] nihavend commented on a change in pull request #227: Feature/mx royale

2018-05-14 Thread GitBox
nihavend commented on a change in pull request #227: Feature/mx royale URL: https://github.com/apache/royale-asjs/pull/227#discussion_r188077335 ## File path: frameworks/projects/MXRoyale/src/main/royale/mx/utils/Base64Encoder.as ## @@ -0,0 +1,435 @@

[GitHub] jgranick opened a new issue #232: (Feature Request) Support for JS externs with royale-js

2018-05-14 Thread GitBox
jgranick opened a new issue #232: (Feature Request) Support for JS externs with royale-js URL: https://github.com/apache/royale-asjs/issues/232 This is probably a known issue, but it would be awesome if we could use the (much cleaner) `royale-js` package for generating extern SWC files

[GitHub] jgranick opened a new issue #229: Path to "playerglobal.swc" wrong in royale-js-swf package

2018-05-14 Thread GitBox
jgranick opened a new issue #229: Path to "playerglobal.swc" wrong in royale-js-swf package URL: https://github.com/apache/royale-asjs/issues/229 ``` +royalelib=../node_modules/@apache-royale/royale-js-swf/royale-asjs/frameworks --keep-as3-metadata+=JSModule --source-path+=../lib

[GitHub] jgranick commented on issue #232: (Feature Request) Support for JS extern output with royale-js

2018-05-14 Thread GitBox
jgranick commented on issue #232: (Feature Request) Support for JS extern output with royale-js URL: https://github.com/apache/royale-asjs/issues/232#issuecomment-388916990 Sure thing! :smile: Here's a quick sample: https://github.com/jgranick/MinimalSWCTest I tried

[GitHub] jgranick opened a new issue #230: The NPM install for royale-js-swf does not allow -y, --yes or other ways to confirm automatically

2018-05-14 Thread GitBox
jgranick opened a new issue #230: The NPM install for royale-js-swf does not allow -y, --yes or other ways to confirm automatically URL: https://github.com/apache/royale-asjs/issues/230 In order to use `royale-js-swf` on a build or continuous integration server, it is necessary to be able

[GitHub] aharui commented on issue #232: (Feature Request) Support for JS extern output with royale-js

2018-05-14 Thread GitBox
aharui commented on issue #232: (Feature Request) Support for JS extern output with royale-js URL: https://github.com/apache/royale-asjs/issues/232#issuecomment-388905773 Do you have test cases so we can make sure we understand what you are looking for? I don't think we have any

[GitHub] jgranick commented on issue #232: (Feature Request) Support for JS extern output with royale-js

2018-05-14 Thread GitBox
jgranick commented on issue #232: (Feature Request) Support for JS extern output with royale-js URL: https://github.com/apache/royale-asjs/issues/232#issuecomment-388917652 For the second case, here's a little sample. It's using one class path, but in our case we'd expect instead to add

[GitHub] jgranick opened a new issue #231: "WARN tar invalid entry" when installing from NPM

2018-05-14 Thread GitBox
jgranick opened a new issue #231: "WARN tar invalid entry" when installing from NPM URL: https://github.com/apache/royale-asjs/issues/231 Both `royale-js` and `royale-js-swf` print the following warning many times: ``` WARN tar invalid entry ``` This floods our output,

[GitHub] jgranick opened a new issue #233: ASDoc comments are not available after making an @externs SWC

2018-05-14 Thread GitBox
jgranick opened a new issue #233: ASDoc comments are not available after making an @externs SWC URL: https://github.com/apache/royale-asjs/issues/233 Hi guys, I am not sure if this is an issue with "royale-js-swf" or with the "ActionScript & MXML" extension for Visual Studio Code.

[GitHub] jgranick opened a new issue #234: Calling a class `Entry` results in a NullPointerException

2018-05-14 Thread GitBox
jgranick opened a new issue #234: Calling a class `Entry` results in a NullPointerException URL: https://github.com/apache/royale-asjs/issues/234 The pattern was simply: ```as3 package { public class Entry { public function Entry { new App ();