[GitHub] nihavend edited a comment on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
nihavend edited a comment on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437484597 I checked the code again removing Module from SparkRoyaleClasses.as. Module references are all in as part of mxml. I guess i can leave manifest as

[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library

2018-11-09 Thread GitBox
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437532076 Interesting. The interface shouldn't be in the requires list. But after we fix

[GitHub] aharui closed issue #57: Dependency error when extending class and implementing interface from "external" SWC library

2018-11-09 Thread GitBox
aharui closed issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57 This is an automated message from the Apache Git

[GitHub] aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-09 Thread GitBox
aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437566014 Check out how Ace Editor is available in Royale. There is a frameworks/projects/Ace SWC and an

[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library

2018-11-09 Thread GitBox
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437565834 I think we should be able to add an "Externs" compiler target (like we have for SWF

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437565547 If you are using Spark Module in MXML files, what errors are you currently getting if Module is mapped to MX Module? Adding Spark Module to

[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library

2018-11-09 Thread GitBox
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437565706 You should be able to pass these options to GCC via the Royale compiler. I think the

[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437565456 Thanks for experimenting. I agree with your sentiments about the amount of code in the styles setter. Some options we

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437484597 I checked the code again removing Module from SparkRoyaleClasses.as. Module references are all in as part of mxml. I guess i can leave manifest as is and

[GitHub] kennylerma commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library

2018-11-09 Thread GitBox
kennylerma commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437539707 Thanks @aharui. I have a work-around, but it's not very elegant. I have a large

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437478181 To be clear, you would not remove mx.modules.Module.as. The spark-royale-manifest.xml (and any MXML manifest) creates a mapping of MXML tags to actual

[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437476563 Yes, good point that BindableCSSStyles needs a reference to its "host". So thinking about this some more, there are two

[GitHub] hcsuk opened a new pull request #342: Switching from using a new HTTPStatusEvent to a ValueEvent, now with …

2018-11-09 Thread GitBox
hcsuk opened a new pull request #342: Switching from using a new HTTPStatusEvent to a ValueEvent, now with … URL: https://github.com/apache/royale-asjs/pull/342 Following the discussion on pull request #340 this update removes the additional HTTPStatusEvent class, and instead we use a

[GitHub] nihavend edited a comment on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
nihavend edited a comment on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437479543 It is more clear now, I am not sure that spark Module is working as mx Module. I am not at the point of things to check if working but trying to

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437479543 It is more clear now, I am not sure that spark Module is working as mx Module. I am not at the point of things to check if working but trying to remove

[GitHub] flexicious opened a new issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-09 Thread GitBox
flexicious opened a new issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343 We are trying out royale, and I was wondering can I put highcharts (or any other third party javascript component) within

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437480561 It depends on what errors you are getting. If you are just referencing the class from AS, you can include the class in SparkRoyaleClasses.as but not change

[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437487171 Okay - I'm having a bit of a play with this and will see what works.. about to stop for the evening to become a taxi service for

[GitHub] Harbs commented on issue #338: Question: How TLF measures text?

2018-11-09 Thread GitBox
Harbs commented on issue #338: Question: How TLF measures text? URL: https://github.com/apache/royale-asjs/issues/338#issuecomment-437318481 TLF itself is ported, but there's quite a few caveats. TLF required FTE to work properly. The text engine was propriety code. For TLF to

[GitHub] devlfm commented on issue #338: Question: How TLF measures text?

2018-11-09 Thread GitBox
devlfm commented on issue #338: Question: How TLF measures text? URL: https://github.com/apache/royale-asjs/issues/338#issuecomment-437316174 @aharui @carlosrovira someone ? This is an automated message from the Apache Git

[GitHub] kennylerma closed issue #42: Update Closure Compiler for removal of google dependencies in WHITESPACE_ONLY mode

2018-11-09 Thread GitBox
kennylerma closed issue #42: Update Closure Compiler for removal of google dependencies in WHITESPACE_ONLY mode URL: https://github.com/apache/royale-compiler/issues/42 This is an automated message from the Apache Git

[GitHub] hcsuk opened a new pull request #340: URLLoader: HTTPStatusEvent addition

2018-11-09 Thread GitBox
hcsuk opened a new pull request #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340 Adding an HTTPStatusEvent into the JS-based code. We've found that this is required by some applications and it seems to make sense to expose this to client code.

[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437452380 Actually, I was thinking of pulling out that UIBase.styleChangeHandler. Ideally, because of PAYG, we could devise a solution

[GitHub] hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition

2018-11-09 Thread GitBox
hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437456584 Thanks - I had wondered about using the ValueEvent .. my main concern with that was the typing, where it's after an Object type. If it was a * it

[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437461172 Okay yes good point (and I definitely like the way that most of the Royale classes are very small - makes them easy to

[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437463001 It would be PAYG to have a variant of SimpleCSSValuesImpl that expects runtime changes to styles, but couldn't all of the code

[GitHub] hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition

2018-11-09 Thread GitBox
hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437464342 Having the * type makes me a little uncomfortable but that's just because of my background in strongly typed languages probably! and also knowing

[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437466684 To do this, there would need to be a link created between the UI object (UIBase), and the BindableCSSStyles object, so that the

[GitHub] aharui commented on issue #340: URLLoader: HTTPStatusEvent addition

2018-11-09 Thread GitBox
aharui commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437467293 IMO, Object is as weak as *. Object is used in Flash often as "Any but not undefined". So changing to * probably wouldn't make things

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437474507 I am using spark spark.modules.Module so added mapping. Anyone using mx.modules.Module may stilll need that mapping i guess. If not than i canre remove mx

[GitHub] hcsuk opened a new pull request #341: Adding listener for when a bindable style has changed

2018-11-09 Thread GitBox
hcsuk opened a new pull request #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341 There was already an event handler for this, but it wasn't being hooked up... If we have some bindable styles, they are being updated by the

[GitHub] kennylerma opened a new issue #57: Dependency error when extending class from "external" SWC library

2018-11-09 Thread GitBox
kennylerma opened a new issue #57: Dependency error when extending class from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57 The included TEST.swc has a simple TestClass class in it. The swc is compiled correctly and includes the javascript. When I use