[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox 
nihavend commented on issue #339: Spark Module class added.
URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437648169
 
 
   Exactly this is what i am saying @aharui. I added the import to  
SparkRoyaleClasses and errors go away.
   
   ContainerCreationPolicy was weak reference in Module, i removed it from 
MXRoyaleClasses and updated the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox 
nihavend commented on issue #339: Spark Module class added.
URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437567219
 
 
   I should have been more clear @aharui. Spark Module is part of MXML but in 
the action script part of mxml. 
   
   So here are the steps and the error :
   
   1. comment out the import in SparkRoyaleClasses
   2. build spark royale
   3. build my project
   4. get the error : 
   
   ```
   
D:\dev\royale-emulation-works\github\pinaraui-royale\PinaraUI\src\com\likya\pinara\comps\jobdetail\JobBaseInfo.mxml(19):
 col: 11 Warning: Definition spark.modules.Module could not be found.
import spark.modules.Module;
   ^
   
D:\dev\royale-emulation-works\github\pinaraui-royale\PinaraUI\src\com\likya\pinara\comps\jobdetail\JobBaseInfo.mxml(21):
 col: 32 Error: Type was not found or was not a compile-time constant: Module.
private var remoteSchModule:Module;
^
   ```
   Here is the part of script :
   ```
import spark.modules.Module;
private var remoteSchModule:Module;
   ```
   Ref : 
https://github.com/likyateknoloji/pinaraui-royale/blob/master/PinaraUI/src/com/likya/pinara/comps/jobdetail/JobBaseInfo.mxml


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox 
nihavend commented on issue #339: Spark Module class added.
URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437484597
 
 
   I checked the code again removing Module from SparkRoyaleClasses.as. Module 
references are all in as part of  mxml. I guess i can leave manifest as is and 
the import to SparkRoyaleClasses.as.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox 
nihavend commented on issue #339: Spark Module class added.
URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437479543
 
 
   It is more clear now, I am not sure that spark Module is working as mx 
Module. I am not at the point of things to check if working but trying to 
remove compiling errors.  It is better to leave as it is and remove psark 
mapping i guess.
   
   And my question, how can i get rid of compiler arros for s:Module in my code 
then ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox 
nihavend commented on issue #339: Spark Module class added.
URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437474507
 
 
   I am using spark spark.modules.Module so added mapping. Anyone using 
mx.modules.Module may stilll need that mapping i guess. If not than i canre 
remove mx version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services