[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977863#comment-15977863 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12864382/SENTRY-1674.009-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2550/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch, > SENTRY-1674.006-sentry-ha-redesign.patch, > SENTRY-1674.008-sentry-ha-redesign.patch, > SENTRY-1674.009-sentry-ha-redesign.patch, > SENTRY-1674.010-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977836#comment-15977836 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12864393/SENTRY-1674.010-sentry-ha-redesign.patch against sentry-ha-redesign. {color:red}Overall:{color} -1 due to 3 errors {color:red}ERROR:{color} mvn test exited 1 {color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore {color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2551/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch, > SENTRY-1674.006-sentry-ha-redesign.patch, > SENTRY-1674.008-sentry-ha-redesign.patch, > SENTRY-1674.009-sentry-ha-redesign.patch, > SENTRY-1674.010-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977369#comment-15977369 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12864340/SENTRY-1674.008-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2545/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch, > SENTRY-1674.006-sentry-ha-redesign.patch, > SENTRY-1674.008-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977187#comment-15977187 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12864309/SENTRY-1674.006-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2542/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch, > SENTRY-1674.006-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976936#comment-15976936 ] Na Li commented on SENTRY-1674: --- I talked with Kalyan. We both agree that right now, we can accept both my change for this case and Hao's change to work around HIVE-15761. Once HIVE-15761 is fixed, we can remove Hao's change that calls "client.getCurrentNotificationEventId()" > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975452#comment-15975452 ] Na Li commented on SENTRY-1674: --- There are two things to clarify. "Let's focus on this issue. This issue is about avoiding logs in cases where there is update in HMS data. Do you agree that changes done for Sentry-1587 would this issue?" 1. This issue can be fixed simply and safely by changes for this issue. 2. The focus of SENTRY-1587 is not about this issue. Its code change that fixes this issue is a work around for a bug in HIVE-15761, and it introduces overhead and delay. I am OK to keep it temporarily before HIVE issue is fixed. I am NOT OK to take this approach to fix this issue permanently while we have a simple and safe alternative to fix it. "There is another JIRA (SENTRY-1669) for looking up the database to get the current notification id which will address the scenario you mentioned in your comment above." Changes in SENTRY-1649 has to make such change in order to allow start()/stop() HMSFollower multiple times in test. And it also fixes the issue in SENTRY-1669. Sorry for distracting the discussion with this scenario. I just thought about it and put it in writing. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975410#comment-15975410 ] kalyan kumar kalvagadda commented on SENTRY-1674: - [~lina...@cloudera.com] You are taking about a completely different issue. There is another JIRA (SENTRY-1669) for looking up the database to get the current notification id which will address the scenario you mentioned in your comment above. I will be submitting the changes for this once changes for Sentry-1587 are committed. Let's focus on this issue. This issue is about avoiding logs in cases where there is update in HMS data. Do you agree that changes done for Sentry-1587 would this issue? > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975382#comment-15975382 ] Na Li commented on SENTRY-1674: --- There is no conflict between Sentry-1674 and the work around by Hao at Sentry-1587. Right now, we can accept both changes. Once HIVE-15761 is done, we can remove the extra RPC in Hao's work around safely. Hao's change alone does not handle the following scenario: There are two Sentry servers. 1. Sentry_A was leader and processed events until EventID_3. 2. Then zookeeper elected Sentry_B as leader, and Sentry_B processed events until EventID_5. 3. Then zookeeper elected Sentry_A as leader again. Now, the latest EventId from HMS meta store is EventID_5, and Sentry_A wants to process the Events 4 and 5 (which are already processed by Sentry_B). Therefore, we need to commit my changes in SENTRY_1649 soon, so the currentEventID is polled from DB in each run (not just in HMSFollower constructor) > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974572#comment-15974572 ] kalyan kumar kalvagadda commented on SENTRY-1674: - [~lina...@cloudera.com] I'm fine with fixing this either of the jira's. I'm concerned about the fix. As we know that ObjectStore.getNextNotification can return exception until HIVE-15761, I would prefer the change made by Hao. It's a safe solution. You had an opinion that it is not optimal. I would say, it if fine. HMSfollower is a background thread that runs periodically to get the updates from HMS. Most of times it might not see any updates. Situations where HMSfollower sees that there is an update, there will be two requests sent. That is not big deal. As HA is a new feature and lot of new functionality in place, I would prefer a change which is consistent. More over fixing HIVE-15761 upstream and backporting it to CDH is an additional effort that we have put. At this point we are not sure which version of Hive would be compatible with the new notification log mechanism that sentry is using for HA. There are a lot of variables there. Let's not depend on the fix for HIVE-15761. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974053#comment-15974053 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12863935/SENTRY-1674.005-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2534/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch, > SENTRY-1674.005-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973315#comment-15973315 ] kalyan kumar kalvagadda commented on SENTRY-1674: - [~akolb] Issue that we trying to address in this jira is to avoid unnecessary logging. This is addressed in SENTRY-1587. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973300#comment-15973300 ] Alexander Kolbasov commented on SENTRY-1674: [~kkalyan] [~hahao] The purpose of this JIRA is to improve logging. SENTRY-1587 has a different scope and it isn't integrated yet. So why not implement something simple now and if there is a better way to do it in SENTRY-1587 it can be addressed there. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973273#comment-15973273 ] Hao Hao commented on SENTRY-1674: - Agree with [~kkalyan] No need to introduce a new variable to record lastLoggedEventId as we already have {{currentEventID}} to keep track of current event id. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973203#comment-15973203 ] kalyan kumar kalvagadda commented on SENTRY-1674: - Fix for this issue is already available in SENTRY-1587 > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973198#comment-15973198 ] Alexander Kolbasov commented on SENTRY-1674: Transferring +1 from reviewboard. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972180#comment-15972180 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12863736/SENTRY-1674.004-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2530/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch, > SENTRY-1674.004-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971724#comment-15971724 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12863667/SENTRY-1674.002-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2526/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1674.002-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1674) HMSFollower shouldn't print the same value of notification ID multiple times
[ https://issues.apache.org/jira/browse/SENTRY-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971585#comment-15971585 ] Hadoop QA commented on SENTRY-1674: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12863667/SENTRY-1674.002-sentry-ha-redesign.patch against sentry-ha-redesign. {color:green}Overall:{color} +1 all checks pass {color:green}SUCCESS:{color} all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2525/console This message is automatically generated. > HMSFollower shouldn't print the same value of notification ID multiple times > > > Key: SENTRY-1674 > URL: https://issues.apache.org/jira/browse/SENTRY-1674 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Na Li >Priority: Minor > Labels: bite-sized, newbie > Fix For: sentry-ha-redesign > > Attachments: SENTRY-1649.019-sentry-ha-redesign.patch, > SENTRY-1674.002-sentry-ha-redesign.patch > > > HMSFollower currently prints current value of notification ID which usually > stays the same. This just pollutes logs. It should only print changes to the > value. -- This message was sent by Atlassian JIRA (v6.3.15#6346)