[jira] [Commented] (SENTRY-2088) Use common SLF4J APIs instead of LOG4J directly to allow support of different LOG4J versions

2018-12-13 Thread Benito Kestelman (JIRA) 


[ 
https://issues.apache.org/jira/browse/SENTRY-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720534#comment-16720534
 ] 

Benito Kestelman commented on SENTRY-2088:
--

I am not, go ahead. 

> Use common SLF4J APIs instead of LOG4J directly to allow support of different 
> LOG4J versions
> 
>
> Key: SENTRY-2088
> URL: https://issues.apache.org/jira/browse/SENTRY-2088
> Project: Sentry
>  Issue Type: Improvement
>  Components: Sentry
>Affects Versions: 2.0.0
>Reporter: Sergio Peña
>Priority: Major
>  Labels: newbie
>
> Sentry uses a couple of different APIs to log messages, some are from SLF4J 
> and others are from LOG4J dependencies.
> For instance:
> {noformat}
> SLF4J api:
>Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);
> LOG4J api:
>Logger LOGGER = LogManager.getLogger(className);
> {noformat}
> The use of getLogger() is not consistent on Sentry and causes conflicts when 
> someone puts a Log4j v2 on the classpath. SLF4J is an interface that uses the 
> Log4j implementation detected at runtime. We should use Slf4j APIs to verify 
> Sentry can work with any version of Log4j.
>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SENTRY-2088) Use common SLF4J APIs instead of LOG4J directly to allow support of different LOG4J versions

2018-12-13 Thread Haley Reeve (JIRA) 


[ 
https://issues.apache.org/jira/browse/SENTRY-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720505#comment-16720505
 ] 

Haley Reeve commented on SENTRY-2088:
-

[~bkestelman], are you working on this? If not I was going to take a look at it.

> Use common SLF4J APIs instead of LOG4J directly to allow support of different 
> LOG4J versions
> 
>
> Key: SENTRY-2088
> URL: https://issues.apache.org/jira/browse/SENTRY-2088
> Project: Sentry
>  Issue Type: Improvement
>  Components: Sentry
>Affects Versions: 2.0.0
>Reporter: Sergio Peña
>Priority: Major
>  Labels: newbie
>
> Sentry uses a couple of different APIs to log messages, some are from SLF4J 
> and others are from LOG4J dependencies.
> For instance:
> {noformat}
> SLF4J api:
>Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);
> LOG4J api:
>Logger LOGGER = LogManager.getLogger(className);
> {noformat}
> The use of getLogger() is not consistent on Sentry and causes conflicts when 
> someone puts a Log4j v2 on the classpath. SLF4J is an interface that uses the 
> Log4j implementation detected at runtime. We should use Slf4j APIs to verify 
> Sentry can work with any version of Log4j.
>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SENTRY-2088) Use common SLF4J APIs instead of LOG4J directly to allow support of different LOG4J versions

2018-09-14 Thread Benito Kestelman (JIRA) 


[ 
https://issues.apache.org/jira/browse/SENTRY-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615056#comment-16615056
 ] 

Benito Kestelman commented on SENTRY-2088:
--

Some of the classes using log4j call Logger.getEffectiveLevel(), which is not 
available in slf4j. 

How should this be handled? 

> Use common SLF4J APIs instead of LOG4J directly to allow support of different 
> LOG4J versions
> 
>
> Key: SENTRY-2088
> URL: https://issues.apache.org/jira/browse/SENTRY-2088
> Project: Sentry
>  Issue Type: Improvement
>  Components: Sentry
>Affects Versions: 2.0.0
>Reporter: Sergio Peña
>Priority: Major
>  Labels: newbie
>
> Sentry uses a couple of different APIs to log messages, some are from SLF4J 
> and others are from LOG4J dependencies.
> For instance:
> {noformat}
> SLF4J api:
>Logger LOGGER = LoggerFactory.getLogger(GMAuditMetadataLogEntity.class);
> LOG4J api:
>Logger LOGGER = LogManager.getLogger(className);
> {noformat}
> The use of getLogger() is not consistent on Sentry and causes conflicts when 
> someone puts a Log4j v2 on the classpath. SLF4J is an interface that uses the 
> Log4j implementation detected at runtime. We should use Slf4j APIs to verify 
> Sentry can work with any version of Log4j.
>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)