[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691657#comment-16691657 ] ASF GitHub Bot commented on SCB-1028: - asifdxtreme closed pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docker-compose.yml b/docker-compose.yml index 9a9a01dc..c7be231e 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,3 +1,19 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- version: '3' services: etcd: diff --git a/docs/release/Readme.md b/docs/release/Readme.md index 3ceb1763..e01bca87 100644 --- a/docs/release/Readme.md +++ b/docs/release/Readme.md @@ -28,7 +28,7 @@ cp apache-rat-0.12/apache-rat-0.12.jar ./ Run the Rat tool using the below command ``` -java -jar apache-rat-0.12.jar -a -d servicecomb-service-center/ -e *.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses** bower.json +java -jar apache-rat-0.12.jar -a -d servicecomb-service-center/ -e *.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses** bower.json cert_pwd *.cer *.tpl glide.yaml go.mod go.sum ``` Below is the list of the files which has been excluded from the list of RAT tool. @@ -36,7 +36,9 @@ Below is the list of the files which has been excluded from the list of RAT tool - .gitignore .gitmodules .travis.yml : Skip the git files and travis file. - manifest **vendor : Skip manifest and all the files under vendor. - bower.json : Skip bower installation file - + - cert_pwd server.cer trust.cer : Skip ssl files + - *.tpl : Ignore template files + - glide.yaml go.mod go.sum : Skip dependency config files You can access the latest RAT report [here](/docs/release/rat-report) diff --git a/examples/infrastructures/docker/docker-compose.yml b/examples/infrastructures/docker/docker-compose.yml index bab0ac45..b54a2106 100644 --- a/examples/infrastructures/docker/docker-compose.yml +++ b/examples/infrastructures/docker/docker-compose.yml @@ -1,3 +1,19 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- version: '3' services: prometheus: diff --git a/examples/infrastructures/docker/prometheus.yml b/examples/infrastructures/docker/prometheus.yml index 514df3b8..f1c203c6 100644 --- a/examples/infrastructures/docker/prometheus.yml +++ b/examples/infrastructures/docker/prometheus.yml @@ -1,3 +1,20 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691471#comment-16691471 ] ASF GitHub Bot commented on SCB-1028: - little-cui commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234548347 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: this is grpc mechanism, sc need to export these interfaces. Users can import it from this repository This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691464#comment-16691464 ] ASF GitHub Bot commented on SCB-1028: - asifdxtreme commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234547129 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: I think so its required, @little-cui can give more detail to this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691459#comment-16691459 ] ASF GitHub Bot commented on SCB-1028: - WillemJiang commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234546036 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: If it's generated, do we still need to add this file into repository? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691327#comment-16691327 ] ASF GitHub Bot commented on SCB-1028: - codecov-io edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784325 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=h1) Report > Merging [#494](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) ```diff @@Coverage Diff @@ ## master #494 +/- ## == + Coverage 59.72% 59.74% +0.01% == Files 165 165 Lines 1379613796 == + Hits 8240 8242 +2 Misses 4973 4973 + Partials 583 581 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/services.pb.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vc2VydmljZXMucGIuZ28=) | `4.51% <ø> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=footer). Last update [413eacb...bf81340](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691326#comment-16691326 ] ASF GitHub Bot commented on SCB-1028: - codecov-io edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784325 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=h1) Report > Merging [#494](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) ```diff @@Coverage Diff @@ ## master #494 +/- ## == + Coverage 59.72% 59.74% +0.01% == Files 165 165 Lines 1379613796 == + Hits 8240 8242 +2 Misses 4973 4973 + Partials 583 581 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/services.pb.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vc2VydmljZXMucGIuZ28=) | `4.51% <ø> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=footer). Last update [413eacb...bf81340](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691328#comment-16691328 ] ASF GitHub Bot commented on SCB-1028: - coveralls edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784337 [](https://coveralls.io/builds/20174008) Coverage increased (+0.1%) to 62.224% when pulling **bf81340e5832f4730e314ccb60eb8e1f29fc5885 on asifdxtreme:master** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691323#comment-16691323 ] ASF GitHub Bot commented on SCB-1028: - coveralls edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784337 [](https://coveralls.io/builds/20173967) Coverage decreased (-0.01%) to 62.113% when pulling **bf81340e5832f4730e314ccb60eb8e1f29fc5885 on asifdxtreme:master** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691322#comment-16691322 ] ASF GitHub Bot commented on SCB-1028: - codecov-io edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784325 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=h1) Report > Merging [#494](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) ```diff @@Coverage Diff @@ ## master #494 +/- ## == + Coverage 59.72% 59.74% +0.01% == Files 165 165 Lines 1379613796 == + Hits 8240 8242 +2 Misses 4973 4973 + Partials 583 581 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/services.pb.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vc2VydmljZXMucGIuZ28=) | `4.51% <ø> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=footer). Last update [413eacb...bf81340](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691320#comment-16691320 ] ASF GitHub Bot commented on SCB-1028: - coveralls edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784337 [](https://coveralls.io/builds/20173943) Coverage increased (+0.04%) to 62.164% when pulling **bf81340e5832f4730e314ccb60eb8e1f29fc5885 on asifdxtreme:master** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691321#comment-16691321 ] ASF GitHub Bot commented on SCB-1028: - codecov-io edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784325 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=h1) Report > Merging [#494](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) ```diff @@Coverage Diff @@ ## master #494 +/- ## == - Coverage 59.72% 59.72% -0.01% == Files 165 165 Lines 1379613796 == - Hits 8240 8239 -1 Misses 4973 4973 - Partials 583 584 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/services.pb.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vc2VydmljZXMucGIuZ28=) | `4.51% <ø> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=footer). Last update [413eacb...bf81340](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691319#comment-16691319 ] ASF GitHub Bot commented on SCB-1028: - coveralls edited a comment on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784337 [](https://coveralls.io/builds/20173891) Coverage increased (+0.09%) to 62.221% when pulling **bf81340e5832f4730e314ccb60eb8e1f29fc5885 on asifdxtreme:master** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691290#comment-16691290 ] ASF GitHub Bot commented on SCB-1028: - codecov-io commented on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784325 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=h1) Report > Merging [#494](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/413eacb2ec3a0b24344f439afaf4737822e06c2e?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) ```diff @@Coverage Diff @@ ## master #494 +/- ## == + Coverage 59.72% 59.73% +<.01% == Files 165 165 Lines 1379613796 == + Hits 8240 8241 +1 Misses 4973 4973 + Partials 583 582 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `67.56% <0%> (+1.35%)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/494/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `48.43% <0%> (+1.56%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=footer). Last update [413eacb...0730544](https://codecov.io/gh/apache/servicecomb-service-center/pull/494?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691291#comment-16691291 ] ASF GitHub Bot commented on SCB-1028: - coveralls commented on issue #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#issuecomment-439784337 [](https://coveralls.io/builds/20173509) Coverage increased (+0.1%) to 62.248% when pulling **0730544227f1385f883c5be7e4d277bbc7600746 on asifdxtreme:master** into **413eacb2ec3a0b24344f439afaf4737822e06c2e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691285#comment-16691285 ] ASF GitHub Bot commented on SCB-1028: - asifdxtreme opened a new pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
