[jira] [Commented] (SCB-343) Batch delete micro-services and enable tracing will cause SC crash
[ https://issues.apache.org/jira/browse/SCB-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361786#comment-16361786 ] ASF GitHub Bot commented on SCB-343: coveralls commented on issue #282: SCB-343 Batch delete micro-services and enable tracing will cause SC crash URL: https://github.com/apache/incubator-servicecomb-service-center/pull/282#issuecomment-364961544 [](https://coveralls.io/builds/15496863) Coverage increased (+0.1%) to 74.144% when pulling **f96ba9676d1a1ceadf1d126d908e5496fec7ce19 on little-cui:release** into **cffba0d6aeef8c1da2278b137a950575a73719ec on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch delete micro-services and enable tracing will cause SC crash > -- > > Key: SCB-343 > URL: https://issues.apache.org/jira/browse/SCB-343 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-343) Batch delete micro-services and enable tracing will cause SC crash
[ https://issues.apache.org/jira/browse/SCB-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361759#comment-16361759 ] ASF GitHub Bot commented on SCB-343: coveralls commented on issue #282: SCB-343 Batch delete micro-services and enable tracing will cause SC crash URL: https://github.com/apache/incubator-servicecomb-service-center/pull/282#issuecomment-364961544 [](https://coveralls.io/builds/15496655) Coverage increased (+0.04%) to 74.041% when pulling **f7c706887eae4fa375c7937ac4b66e9e07035982 on little-cui:release** into **cffba0d6aeef8c1da2278b137a950575a73719ec on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch delete micro-services and enable tracing will cause SC crash > -- > > Key: SCB-343 > URL: https://issues.apache.org/jira/browse/SCB-343 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-343) Batch delete micro-services and enable tracing will cause SC crash
[ https://issues.apache.org/jira/browse/SCB-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360911#comment-16360911 ] ASF GitHub Bot commented on SCB-343: coveralls commented on issue #282: SCB-343 Batch delete micro-services and enable tracing will cause SC crash URL: https://github.com/apache/incubator-servicecomb-service-center/pull/282#issuecomment-364961544 [](https://coveralls.io/builds/15486155) Coverage increased (+0.02%) to 74.022% when pulling **eb8acb66f9cf7414ceeb5707c43f57089943340d on little-cui:release** into **cffba0d6aeef8c1da2278b137a950575a73719ec on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch delete micro-services and enable tracing will cause SC crash > -- > > Key: SCB-343 > URL: https://issues.apache.org/jira/browse/SCB-343 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-343) Batch delete micro-services and enable tracing will cause SC crash
[ https://issues.apache.org/jira/browse/SCB-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360909#comment-16360909 ] ASF GitHub Bot commented on SCB-343: codecov-io commented on issue #282: SCB-343 Batch delete micro-services and enable tracing will cause SC crash URL: https://github.com/apache/incubator-servicecomb-service-center/pull/282#issuecomment-364961368 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=h1) Report > Merging [#282](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/cffba0d6aeef8c1da2278b137a950575a73719ec?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#282 +/- ## = + Coverage 70.36% 70.4% +0.04% = Files 17 17 Lines34183413 -5 = - Hits 24052403 -2 + Misses846 842 -4 - Partials 167 168 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `68.91% <ø> (+0.46%)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `49.09% <ø> (-0.63%)` | :arrow_down: | | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.16% <100%> (+0.04%)` | :arrow_up: | | [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `74.6% <100%> (+0.15%)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `75.43% <0%> (-0.59%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=footer). Last update [cffba0d...eb8acb6](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/282?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch delete micro-services and enable tracing will cause SC crash > -- > > Key: SCB-343 > URL: https://issues.apache.org/jira/browse/SCB-343 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-343) Batch delete micro-services and enable tracing will cause SC crash
[ https://issues.apache.org/jira/browse/SCB-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360851#comment-16360851 ] ASF GitHub Bot commented on SCB-343: little-cui opened a new pull request #282: SCB-343 Batch delete micro-services and enable tracing will cause SC crash URL: https://github.com/apache/incubator-servicecomb-service-center/pull/282 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch delete micro-services and enable tracing will cause SC crash > -- > > Key: SCB-343 > URL: https://issues.apache.org/jira/browse/SCB-343 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
