[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396651#comment-16396651
 ] 

ASF GitHub Bot commented on SCB-382:


WillemJiang closed pull request #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/demo/docker-run-config/pom.xml b/demo/docker-run-config/pom.xml
index b6586803d..52ba50f83 100644
--- a/demo/docker-run-config/pom.xml
+++ b/demo/docker-run-config/pom.xml
@@ -89,7 +89,7 @@
 8080:8080
 
 
-service-center
+service-center
 
 
 
diff --git a/integration-tests/dynamic-config-tests/pom.xml 
b/integration-tests/dynamic-config-tests/pom.xml
index 5c4f65d94..f0ab7c8fb 100644
--- a/integration-tests/dynamic-config-tests/pom.xml
+++ b/integration-tests/dynamic-config-tests/pom.xml
@@ -99,7 +99,9 @@
   apollo.config:8080
   apollo.portal:8070
 
-mysql
+
+  mysql
+
   
 
   


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396638#comment-16396638
 ] 

ASF GitHub Bot commented on SCB-382:


coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372017538
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15944039/badge)](https://coveralls.io/builds/15944039)
   
   Coverage decreased (-0.02%) to 87.183% when pulling 
**c96a1447e86c09cdc5ebe406f3f89d4c8fefab68 on zhengyangyong:SCB-382** into 
**0c2e8d55f10e55174427429f58376a06be9cf5b2 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394382#comment-16394382
 ] 

ASF GitHub Bot commented on SCB-382:


WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679
 
 
   Tested on macOSX,  the test was blocked  when starting the contianer, so we 
cannot merge for 1.0.0-m1 release.
   I just tested docker plugin 0.23.0, the dynamic configuration integration 
test is passed,  but for the docker plugin 0.24.0, the plugin cannot get the 
log input there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394184#comment-16394184
 ] 

ASF GitHub Bot commented on SCB-382:


WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679
 
 
   Tested on macOSX,  the test was blocked  when starting the contianer, so we 
cannot merge for 1.0.0-m1 release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394180#comment-16394180
 ] 

ASF GitHub Bot commented on SCB-382:


WillemJiang commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372032679
 
 
   Tested on macOSX,  the test is blocked, so we cannot merge for 1.0.0-m1 
release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394115#comment-16394115
 ] 

ASF GitHub Bot commented on SCB-382:


coveralls commented on issue #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/584#issuecomment-372017538
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15907157/badge)](https://coveralls.io/builds/15907157)
   
   Coverage increased (+0.02%) to 87.206% when pulling 
**58e75a3f3dd410272d7c7acd6a97c91c3305b375 on zhengyangyong:SCB-382** into 
**17137b5905940094f804451aacc5a7c21e711aea on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-382) Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting

2018-03-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SCB-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394109#comment-16394109
 ] 

ASF GitHub Bot commented on SCB-382:


zhengyangyong opened a new pull request #584: [SCB-382] upgrade io.fabric8 
docker-maven-plugin version and fix depends-on setting
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/584
 
 
   …s-on setting
   
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   More detail can be found : https://dmp.fabric8.io/#start-depends-on
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade io.fabric8 docker-maven-plugin version and fix depends-on setting
> -
>
> Key: SCB-382
> URL: https://issues.apache.org/jira/browse/SCB-382
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> more detail : [https://dmp.fabric8.io/#start-depends-on]
> {{  postgres 
> logstash }}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)