[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478714#comment-16478714 ] ASF GitHub Bot commented on SCB-393: little-cui closed pull request #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/integration/instances_test.go b/integration/instances_test.go index 948c9f62..50043210 100644 --- a/integration/instances_test.go +++ b/integration/instances_test.go @@ -168,6 +168,7 @@ var _ = Describe("MicroService Api Test", func() { "times":2, } instance := map[string]interface{}{ + "instanceId": serviceInstanceID, "endpoints": endpoints, "hostName":"cse", "status": "UP", diff --git a/pkg/util/backoff.go b/pkg/util/backoff.go new file mode 100644 index ..7f96cfd0 --- /dev/null +++ b/pkg/util/backoff.go @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package util + +import ( + "math" + "time" +) + +var DefaultBackoff Backoff = &PowerBackoff{ + MaxDelay: 30 * time.Second, + InitDelay: 1 * time.Second, + Factor:1.6, +} + +type Backoff interface { + Delay(retries int) time.Duration +} + +// delay = min(MaxDelay, InitDelay * power(Factor, retries)) +type PowerBackoff struct { + MaxDelay time.Duration + InitDelay time.Duration + Factorfloat64 +} + +func (pb *PowerBackoff) Delay(retries int) time.Duration { + if retries <= 0 { + return pb.InitDelay + } + + return time.Duration(math.Min(float64(pb.MaxDelay), float64(pb.InitDelay)*math.Pow(pb.Factor, float64(retries +} + +func GetBackoff() Backoff { + return DefaultBackoff +} diff --git a/pkg/util/backoff_test.go b/pkg/util/backoff_test.go new file mode 100644 index ..301a914f --- /dev/null +++ b/pkg/util/backoff_test.go @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package util + +import ( + "testing" + "time" +) + +func TestPowerBackoff_Delay(t *testing.T) { + i, m := time.Second, 30*time.Second + b := &PowerBackoff{ + MaxDelay: 30 * time.Second, + InitDelay: 1 * time.Second, + Factor:1.6, + } + r := b.Delay(-1) + if r != i { + t.Fatalf("TestPowerBackoff_Delay -1 failed, result is %s", r) + } + r = b.Delay(0) + if r != i { + t.Fatalf("TestPowerBackoff_Delay 0 failed, result is %s", r) + } + r = b.Delay(1) + if r != 1600*time.Millisecond { + t.Fatalf("TestPowerBackoff_Delay 1 failed, result is %s", r) + } + r = b.Delay(4) + if r != 6553600*time.Microsecond { + t.Fatalf("TestPowerBackoff_Delay 4 failed, result is %s", r) + }
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478713#comment-16478713 ] ASF GitHub Bot commented on SCB-393: codecov-io commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389732060 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=h1) Report > Merging [#352](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3618245c56360a24df606a7daf78586ac006dca3?src=pr&el=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `97.43%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/graphs/tree.svg?width=650&src=pr&token=GAaF7zrg8R&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #352 +/- ## == - Coverage 69.88% 69.64% -0.25% == Files 18 18 Lines3420 3406 -14 == - Hits 2390 2372 -18 - Misses865 868 +3 - Partials 165 166 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `68.58% <ø> (-2.56%)` | :arrow_down: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <100%> (ø)` | :arrow_up: | | [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `74.55% <100%> (ø)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.51% <100%> (ø)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `56.37% <100%> (ø)` | :arrow_up: | | [server/service/schema.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hLmdv) | `75% <100%> (ø)` | :arrow_up: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `74.84% <100%> (ø)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `71.64% <100%> (ø)` | :arrow_up: | | [server/service/util/schema\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9zY2hlbWFfdXRpbC5nbw==) | `87.5% <100%> (ø)` | :arrow_up: | | [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `67.5% <100%> (ø)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=footer). Last update [3618245...c7f9bad](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478712#comment-16478712 ] ASF GitHub Bot commented on SCB-393: coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage Status](https://coveralls.io/builds/17027776/badge)](https://coveralls.io/builds/17027776) Coverage decreased (-0.2%) to 73.206% when pulling **c7f9baded846f164d8a789d16d76b024b17ba4a9 on little-cui:master** into **3618245c56360a24df606a7daf78586ac006dca3 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478692#comment-16478692 ] ASF GitHub Bot commented on SCB-393: coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage Status](https://coveralls.io/builds/17027521/badge)](https://coveralls.io/builds/17027521) Coverage increased (+0.01%) to 73.376% when pulling **d6a2e50d9dd37ab3afb7b771286f115a1aa24c9b on little-cui:master** into **3618245c56360a24df606a7daf78586ac006dca3 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478574#comment-16478574 ] ASF GitHub Bot commented on SCB-393: codecov-io commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389732060 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=h1) Report > Merging [#352](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3618245c56360a24df606a7daf78586ac006dca3?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `97.43%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/graphs/tree.svg?width=650&src=pr&token=GAaF7zrg8R&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #352 +/- ## == + Coverage 69.88% 69.91% +0.02% == Files 18 18 Lines3420 3420 == + Hits 2390 2391 +1 Misses865 865 + Partials 165 164 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/schema\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9zY2hlbWFfdXRpbC5nbw==) | `87.5% <100%> (ø)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `71.64% <100%> (ø)` | :arrow_up: | | [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `74.55% <100%> (ø)` | :arrow_up: | | [server/service/schema.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hLmdv) | `75% <100%> (ø)` | :arrow_up: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `74.84% <100%> (ø)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `56.37% <100%> (ø)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <100%> (ø)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.51% <100%> (ø)` | :arrow_up: | | [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `67.5% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `48.36% <88.88%> (ø)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=footer). Last update [3618245...c8b6f73](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated mess
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478573#comment-16478573 ] ASF GitHub Bot commented on SCB-393: coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage Status](https://coveralls.io/builds/17026530/badge)](https://coveralls.io/builds/17026530) Coverage increased (+0.1%) to 73.468% when pulling **c8b6f73ad59a46f2c9246489cfc0a9316648e90f on little-cui:master** into **3618245c56360a24df606a7daf78586ac006dca3 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478435#comment-16478435 ] ASF GitHub Bot commented on SCB-393: codecov-io commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389732060 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=h1) Report > Merging [#352](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3618245c56360a24df606a7daf78586ac006dca3?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `97.43%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/graphs/tree.svg?token=GAaF7zrg8R&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #352 +/- ## == + Coverage 69.88% 69.91% +0.02% == Files 18 18 Lines3420 3420 == + Hits 2390 2391 +1 Misses865 865 + Partials 165 164 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <100%> (ø)` | :arrow_up: | | [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `74.84% <100%> (ø)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `56.37% <100%> (ø)` | :arrow_up: | | [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `74.55% <100%> (ø)` | :arrow_up: | | [server/service/util/schema\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9zY2hlbWFfdXRpbC5nbw==) | `87.5% <100%> (ø)` | :arrow_up: | | [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `71.64% <100%> (ø)` | :arrow_up: | | [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `67.5% <100%> (ø)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.51% <100%> (ø)` | :arrow_up: | | [server/service/schema.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2NoZW1hLmdv) | `75% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `48.36% <88.88%> (ø)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=footer). Last update [3618245...7ff4463](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated mess
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478434#comment-16478434 ] ASF GitHub Bot commented on SCB-393: coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage Status](https://coveralls.io/builds/17025456/badge)](https://coveralls.io/builds/17025456) Coverage increased (+0.1%) to 73.468% when pulling **7ff446331fbd29df31dcaeb78270cf06c07d7b47 on little-cui:master** into **3618245c56360a24df606a7daf78586ac006dca3 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478379#comment-16478379 ] ASF GitHub Bot commented on SCB-393: coveralls commented on issue #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352#issuecomment-389720468 [![Coverage Status](https://coveralls.io/builds/17024811/badge)](https://coveralls.io/builds/17024811) Coverage increased (+0.05%) to 73.415% when pulling **9078caef59b40d3a624d0c3d3d35326a35e423c0 on little-cui:master** into **3618245c56360a24df606a7daf78586ac006dca3 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-393) Retry to request etcd too frequently when fail
[ https://issues.apache.org/jira/browse/SCB-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478362#comment-16478362 ] ASF GitHub Bot commented on SCB-393: little-cui opened a new pull request #352: SCB-393 Retry to request etcd too frequently when fail URL: https://github.com/apache/incubator-servicecomb-service-center/pull/352 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Retry to request etcd too frequently when fail > -- > > Key: SCB-393 > URL: https://issues.apache.org/jira/browse/SCB-393 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)