[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429805#comment-16429805
 ] 

ASF GitHub Bot commented on SCB-462:


wujimin closed pull request #635: [SCB-462] cloud eye publisher switch to new 
mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/635
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml 
b/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml
deleted file mode 100644
index 806d3b4e1..0
--- 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml
+++ /dev/null
@@ -1,88 +0,0 @@
-
-
-
-http://maven.apache.org/POM/4.0.0;
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
-  
-metrics-write-file-sample
-org.apache.servicecomb.samples
-1.0.0-m2-SNAPSHOT
-  
-  4.0.0
-
-  metrics-write-file-log4j-springboot
-
-  
-  
-  
-
-  org.springframework.boot
-  spring-boot-starter
-  
-
-  org.slf4j
-  log4j-over-slf4j
-
-  
-
-
-
-  org.apache.servicecomb
-  spring-boot-starter-provider
-
-
-
-  org.apache.servicecomb
-  handler-flowcontrol-qps
-
-
-  org.apache.servicecomb
-  handler-bizkeeper
-
-
-  org.apache.servicecomb
-  handler-tracing-zipkin
-
-
-  org.hibernate
-  hibernate-validator
-
-
-
-  log4j
-  log4j
-
-
-  org.apache.servicecomb.samples
-  metrics-write-file
-
-  
-
-  
-
-  
-org.springframework.boot
-spring-boot-maven-plugin
-  
-
-  
-
-
\ No newline at end of file
diff --git 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
 
b/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
deleted file mode 100644
index cbe417dd4..0
--- 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.servicecomb.samples.mwf;
-
-import java.nio.file.Paths;
-import java.util.Map;
-
-import org.apache.log4j.Level;
-import org.apache.log4j.Logger;
-import org.apache.log4j.PatternLayout;
-import org.apache.log4j.RollingFileAppender;
-import org.apache.log4j.spi.LoggingEvent;
-import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
-import org.springframework.stereotype.Component;
-
-import com.netflix.config.DynamicPropertyFactory;
-
-@Component
-public class Log4JMetricsFileWriter implements MetricsFileWriter {
-  private static final String METRICS_FILE_ROLLING_MAX_FILE_COUNT = 
"servicecomb.metrics.file.rolling.max_file_count";
-
-  private static final String METRICS_FILE_ROLLING_MAX_FILE_SIZE = 
"servicecomb.metrics.file.rolling.max_file_size";
-
-  private static final String METRICS_FILE_ROOT_PATH = 
"servicecomb.metrics.file.root_path";
-
-
-  private final Map fileAppenders = new 
ConcurrentHashMapEx<>();
-
-  private final int maxFileCount;
-
-  private final String maxFileSize;
-
-  private final String rootPath;
-
-  public Log4JMetricsFileWriter() {
-maxFileCount = 
DynamicPropertyFactory.getInstance().getIntProperty(METRICS_FILE_ROLLING_MAX_FILE_COUNT,
 10).get();
-maxFileSize = DynamicPropertyFactory.getInstance()
-.getStringProperty(METRICS_FILE_ROLLING_MAX_FILE_SIZE, "10MB")
-.get();
-rootPath = 

[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429791#comment-16429791
 ] 

ASF GitHub Bot commented on SCB-462:


coveralls commented on issue #635: [SCB-462] cloud eye publisher switch to new 
mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#issuecomment-379478939
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16406396/badge)](https://coveralls.io/builds/16406396)
   
   Coverage decreased (-0.01%) to 87.597% when pulling 
**aab76a4510436fe08724287ab3b7dc8fcbd0d79f on wujimin:cloudeye-publisher** into 
**49d8249b90c5b303725def283b10b29cdb452f59 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429783#comment-16429783
 ] 

ASF GitHub Bot commented on SCB-462:


wujimin commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179950917
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   stupid mistake
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429731#comment-16429731
 ] 

ASF GitHub Bot commented on SCB-462:


liubao68 commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179944492
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   I think this main class can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429730#comment-16429730
 ] 

ASF GitHub Bot commented on SCB-462:


liubao68 commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179944492
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   I think this test case can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429431#comment-16429431
 ] 

ASF GitHub Bot commented on SCB-462:


coveralls commented on issue #635: [SCB-462] cloud eye publisher switch to new 
mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#issuecomment-379478939
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16399452/badge)](https://coveralls.io/builds/16399452)
   
   Coverage remained the same at 87.605% when pulling 
**edb9ae6ab9a1fb2141ae9d279142de178149eafc on wujimin:cloudeye-publisher** into 
**8a77e34365e786462b74826c724d10f0e735d5fe on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429357#comment-16429357
 ] 

ASF GitHub Bot commented on SCB-462:


wujimin commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179916788
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/resources/sample-log4j2.xml
 ##
 @@ -0,0 +1,29 @@
+
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426592#comment-16426592
 ] 

ASF GitHub Bot commented on SCB-462:


WillemJiang commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179374955
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/resources/sample-log4j2.xml
 ##
 @@ -0,0 +1,29 @@
+
 
 Review comment:
   License header please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-462) cloud eye publisher switch to new mechanism

2018-04-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425191#comment-16425191
 ] 

ASF GitHub Bot commented on SCB-462:


wujimin opened a new pull request #635: [SCB-462] cloud eye publisher switch to 
new mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/635
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cloud eye publisher switch to new mechanism
> ---
>
> Key: SCB-462
> URL: https://issues.apache.org/jira/browse/SCB-462
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)