[jira] [Commented] (SCB-466) improve metrics prometheus and contribute to https://github.com/prometheus/client_java

2018-04-10 Thread yangyongzheng (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431926#comment-16431926
 ] 

yangyongzheng commented on SCB-466:
---

I had try submitted a new exporter module in order to simplify code but not 
accepted : https://github.com/prometheus/client_java/pull/370
We can close this issues now

> improve metrics prometheus and contribute to 
> https://github.com/prometheus/client_java
> --
>
> Key: SCB-466
> URL: https://issues.apache.org/jira/browse/SCB-466
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
>
> currently we only convert spectator measurement to prometheus Sample
> but lost sample type
>  
> before we contribute the code, we should improve the converter better, like: 
> https://github.com/prometheus/client_java/blob/master/simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-466) improve metrics prometheus and contribute to https://github.com/prometheus/client_java

2018-04-09 Thread yangyongzheng (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431602#comment-16431602
 ] 

yangyongzheng commented on SCB-466:
---

1. [https://prometheus.io/docs/concepts/metric_types/]

*The Prometheus server does not yet make use of the type information and 
flattens all data into untyped time series. This may change in the future.*

2. [https://prometheus.io/docs/instrumenting/writing_exporters/]

*Often it won’t be obvious what the type of metric is, especially if you’re 
automatically processing a set of metrics. In general {{UNTYPED}} is a safe 
default.*

 

So,I think use *UNTYPED* is not a big problem.

> improve metrics prometheus and contribute to 
> https://github.com/prometheus/client_java
> --
>
> Key: SCB-466
> URL: https://issues.apache.org/jira/browse/SCB-466
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
>
> currently we only convert spectator measurement to prometheus Sample
> but lost sample type
>  
> before we contribute the code, we should improve the converter better, like: 
> https://github.com/prometheus/client_java/blob/master/simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)