[jira] [Commented] (SCB-469) Remove source code in service-center:1.0.0-m1 docker image
[ https://issues.apache.org/jira/browse/SCB-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437108#comment-16437108 ] ASF GitHub Bot commented on SCB-469: asifdxtreme closed pull request #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/scripts/release/Dockerfile b/scripts/release/Dockerfile new file mode 100644 index ..5d2cdfa4 --- /dev/null +++ b/scripts/release/Dockerfile @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM ubuntu:latest + +ADD ./apache-servicecomb-incubating-service-center-latest-linux-amd64 /release/ + +RUN sed -i 's/httpaddr = 127.0.0.1/httpaddr = 0.0.0.0/g' /release/conf/app.conf + +ENTRYPOINT ["/release/service-center"] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove source code in service-center:1.0.0-m1 docker image > -- > > Key: SCB-469 > URL: https://issues.apache.org/jira/browse/SCB-469 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0-m1 >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Minor > Fix For: service-center-1.0.0-m2 > > > The service-center:1.0.0-m1 docker image contains source code which makes the > image huge(~300M). > Please remove the source code and cleanup /go/data directory and push a new > image to docker hub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-469) Remove source code in service-center:1.0.0-m1 docker image
[ https://issues.apache.org/jira/browse/SCB-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433466#comment-16433466 ] ASF GitHub Bot commented on SCB-469: coveralls commented on issue #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327#issuecomment-380342981 [](https://coveralls.io/builds/16454771) Coverage decreased (-0.05%) to 72.972% when pulling **0e3b896023beb4b53dd63e8f76ee4fbf5abe40f0 on asifdxtreme:master** into **ecc69573695c6b988e09c662654dd0700cc9fed8 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove source code in service-center:1.0.0-m1 docker image > -- > > Key: SCB-469 > URL: https://issues.apache.org/jira/browse/SCB-469 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0-m1 >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Minor > Fix For: service-center-1.0.0-m2 > > > The service-center:1.0.0-m1 docker image contains source code which makes the > image huge(~300M). > Please remove the source code and cleanup /go/data directory and push a new > image to docker hub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-469) Remove source code in service-center:1.0.0-m1 docker image
[ https://issues.apache.org/jira/browse/SCB-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433467#comment-16433467 ] ASF GitHub Bot commented on SCB-469: codecov-io commented on issue #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327#issuecomment-380343090 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=h1) Report > Merging [#327](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ecc69573695c6b988e09c662654dd0700cc9fed8?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #327 +/- ## === Coverage 69.46% 69.46% === Files 17 17 Lines3435 3435 === Hits 2386 2386 Misses883 883 Partials 166 166 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=footer). Last update [ecc6957...0e3b896](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove source code in service-center:1.0.0-m1 docker image > -- > > Key: SCB-469 > URL: https://issues.apache.org/jira/browse/SCB-469 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0-m1 >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Minor > Fix For: service-center-1.0.0-m2 > > > The service-center:1.0.0-m1 docker image contains source code which makes the > image huge(~300M). > Please remove the source code and cleanup /go/data directory and push a new > image to docker hub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-469) Remove source code in service-center:1.0.0-m1 docker image
[ https://issues.apache.org/jira/browse/SCB-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433462#comment-16433462 ] ASF GitHub Bot commented on SCB-469: asifdxtreme opened a new pull request #327: SCB-469 Create a new docker file for the release URL: https://github.com/apache/incubator-servicecomb-service-center/pull/327 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove source code in service-center:1.0.0-m1 docker image > -- > > Key: SCB-469 > URL: https://issues.apache.org/jira/browse/SCB-469 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0-m1 >Reporter: Yang Bo >Assignee: Mohammad Asif Siddiqui >Priority: Minor > Fix For: service-center-1.0.0-m1 > > > The service-center:1.0.0-m1 docker image contains source code which makes the > image huge(~300M). > Please remove the source code and cleanup /go/data directory and push a new > image to docker hub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
