[jira] [Commented] (SCB-661) Logs improvement to give better information
[
https://issues.apache.org/jira/browse/SCB-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512388#comment-16512388
]
ASF GitHub Bot commented on SCB-661:
wujimin closed pull request #766: [SCB-661]logs give more information and
remove unnecessary log for each invocation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/766
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
index 2dd77556d..a3dbbdb3a 100644
---
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
@@ -72,6 +72,7 @@ protected Swagger loadSwagger(ConsumerSchemaContext context) {
context.getMicroservice().getVersion(),
context.getSchemaId(),
!StringUtils.isEmpty(schemaContent));
+LOGGER.debug(schemaContent);
if (schemaContent != null) {
return SchemaUtils.parseSwagger(schemaContent);
}
diff --git
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
index aad3893d1..a582041f2 100644
---
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
+++
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
@@ -79,7 +79,8 @@ protected String getCacheKey() {
invocation.next(resp -> {
if (isFailedResponse(resp)) {
// e should implements toString
-LOG.warn("bizkeeper command failed due to:" + resp.getResult());
+LOG.warn("bizkeeper command {} failed due to {}",
invocation.getInvocationQualifiedName(),
+resp.getResult());
f.onError(resp.getResult());
FallbackPolicyManager.record(type, invocation, resp, false);
} else {
@@ -89,7 +90,8 @@ protected String getCacheKey() {
}
});
} catch (Exception e) {
-LOG.warn("bizkeeper command execute failed due to:" +
e.getClass().getName());
+LOG.warn("bizkeeper command {} execute failed due to {}",
invocation.getInvocationQualifiedName(),
+e.getClass().getName());
f.onError(e);
}
});
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index 723abef24..06ffb9bc1 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -223,7 +223,8 @@ public void onStartWithServer(ExecutionContext
context,
@Override
public void onExceptionWithServer(ExecutionContext context,
Throwable exception,
ExecutionInfo info) {
-LOGGER.error("onExceptionWithServer msg {}; server {}",
+LOGGER.error("onExceptionWithServer operation {}; msg {}; server {}",
+context.getRequest().getInvocationQualifiedName(),
exception.getMessage(),
context.getRequest().getEndpoint());
}
@@ -274,7 +275,8 @@ public void onExecutionFailed(ExecutionContext
context, Throwable fi
invocation.setEndpoint(((CseServer) s).getEndpoint());
invocation.next(resp -> {
if (isFailedResponse(resp)) {
-LOGGER.error("service call error, msg is {}, server is {} ",
+LOGGER.error("service {}, call error, msg is {}, server is {}
",
+invocation.getInvocationQualifiedName(),
((Throwable) resp.getResult()).getMessage(),
s);
chosenLB.getLoadBalancerStats().incrementSuccessiveConnectionFailureCount(s);
diff --git
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
index aaffa3fe2..9c379a9c0 100644
---
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
+++
b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb
[jira] [Commented] (SCB-661) Logs improvement to give better information
[ https://issues.apache.org/jira/browse/SCB-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510899#comment-16510899 ] ASF GitHub Bot commented on SCB-661: coveralls commented on issue #766: [SCB-661]logs give more information and remove unnecessary log for each invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/766#issuecomment-396583667 [](https://coveralls.io/builds/17464445) Coverage increased (+0.008%) to 87.367% when pulling **2e2f6adbc04371134031dbb581ee3e6d8e556b01 on liubao68:pubkey** into **b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logs improvement to give better information > --- > > Key: SCB-661 > URL: https://issues.apache.org/jira/browse/SCB-661 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-661) Logs improvement to give better information
[ https://issues.apache.org/jira/browse/SCB-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509613#comment-16509613 ] ASF GitHub Bot commented on SCB-661: coveralls commented on issue #766: [SCB-661]logs give more information and remove unnecessary log for each invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/766#issuecomment-396583667 [](https://coveralls.io/builds/17445957) Coverage increased (+0.007%) to 87.366% when pulling **449dd25b34bfe4f311d06974d58fdcdc50bf9e61 on liubao68:pubkey** into **b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logs improvement to give better information > --- > > Key: SCB-661 > URL: https://issues.apache.org/jira/browse/SCB-661 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-661) Logs improvement to give better information
[ https://issues.apache.org/jira/browse/SCB-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509580#comment-16509580 ] ASF GitHub Bot commented on SCB-661: liubao68 opened a new pull request #766: [SCB-661]logs give more information and remove unnecessary log for each invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/766 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Logs improvement to give better information > --- > > Key: SCB-661 > URL: https://issues.apache.org/jira/browse/SCB-661 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
