ilariapet opened a new pull request, #3328:
URL: https://github.com/apache/solr/pull/3328
https://issues.apache.org/jira/browse/SOLR-17726
# Description
When using CloudMLTQParser, fields that are populated exclusively via
`copyField` are not taken into account when constructing the MoreLikeThis query.
This happens because CloudMLTQParser relies on a RealTime Get (`/get`)
request to retrieve the source document by ID, and the document returned by
RealTime Get does not include fields generated via copyField (i.e. are not part
of the original SolrIDocument).
As a result, even if the copyField target is stored and has proper
termVectors configured, CloudMLTQParser skips the field silently, and the MLT
query ends up empty.
# Solution
The issue was addressed by introducing a helper method
`getFieldOrCopyFieldValues` that retrieves field values from the source
document returned by RealTime Get.
If a field passed in the `qf` parameter of the MLT query is not directly
present in the document (as is the case for fields populated exclusively via
copyField), the method looks up its copyField sources in the schema and
aggregates their values. These values are then used to construct the input for
MoreLikeThis#like, ensuring that all content (including that of
copyField-derived fields) is properly considered when building the MLT query.
# Tests
Five tests were added to cover different scenarios involving copyField usage
in the qf parameter of the MoreLikeThis query:
- `testUsesACopyFieldInQf_shouldUseTheSourceFieldAndReturnResults`
Verifies that when a copyField destination is used in the qf parameter, the
MLT query correctly retrieves values from the source field(s) and returns
relevant results.
- `testCopyFieldSourceMissing_shouldReturnNoResults`
Ensures that no results are returned when the copyField source field is
missing in the source document.
- `testCopyFieldDestinationNotStored_shouldReturnResults`
Confirms that even if the copyField destination field is not stored, results
can still be returned as long as the source field is stored and contains the
relevant content.
- `testCopyFieldSourceNotStored_shouldReturnNoResults`
Checks that no results are returned if the copyField source field is not
stored, even when the destination field is stored and used in the qf.
- `testCopyFieldDestinationMultiple_shouldReturnResults`
Validates that when multiple source fields map to a single copyField
destination, their values are correctly combined to construct the MLT query,
and appropriate results are returned.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request
title.
- [X] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
