Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley merged PR #3171: URL: https://github.com/apache/solr/pull/3171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley commented on PR #3171: URL: https://github.com/apache/solr/pull/3171#issuecomment-2654944730 Will merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley commented on code in PR #3171:
URL: https://github.com/apache/solr/pull/3171#discussion_r1948227396
##
solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java:
##
@@ -200,25 +201,4 @@ public void testWordListZipfian() {
assertNotNull(field.getValue().toString());
}
-
- @Test
- public void testGenDoc() {
Review Comment:
removed because it had no assertions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[PR] Fix DockMakerTest maxCardinality [solr]
dsmiley opened a new pull request, #3171: URL: https://github.com/apache/solr/pull/3171 See this [thread](https://github.com/apache/solr/pull/254#discussion_r1917413526) > I see a repeating failure running DockMakerTest.testBasicCardinalityAlpha with seed E0BBCB76FA600308 in which every field value is the letter 'k'. This DSL framework is extremely different from any other code most people encounter so it took some time to narrow down the problem to where I'm commenting. This code will choose consecutive seeds for subsequent processing. (Consecutiveness is not a problem I think). For a cardinality of 2 and based on the random test seed, this long seed will be either 635258717 or 635258718. But the next stage will always produce 'k' for either of those seeds; the next stage produces a random string of length from 1 to 6. I think the fundamental fix is in the test; to recognize this is a *max*Cardinality, and weaken its assertions accordingly. I added some comments in StringsDSL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
